Bug 2198973 - Review Request: golang-github-dennwc-btrfs - Btrfs library in a pure Go
Summary: Review Request: golang-github-dennwc-btrfs - Btrfs library in a pure Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2112130
TreeView+ depends on / blocked
 
Reported: 2023-05-10 23:15 UTC by Mark E. Fuller
Modified: 2023-05-18 17:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-18 13:13:23 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Mark E. Fuller 2023-05-10 23:15:24 UTC
Spec URL: https://fuller.fedorapeople.org/prometheus/golang-github-dennwc-btrfs.spec
SRPM URL: https://fuller.fedorapeople.org/prometheus/golang-github-dennwc-btrfs-0-0.1.20230510gita1f570b.fc39.src.rpm
Description: Btrfs library in a pure Go
Fedora Account System Username: fuller

Comment 1 Mikel Olasagasti Uranga 2023-05-15 19:45:38 UTC
Can you change the "disable tests" comment to be before the bcond before pushing?

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 2 Mark E. Fuller 2023-05-17 18:25:52 UTC
No problem on the comment - thank you for the review

Comment 3 Fedora Admin user for bugzilla script actions 2023-05-17 18:29:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dennwc-btrfs

Comment 4 Fedora Update System 2023-05-18 13:12:53 UTC
FEDORA-2023-8c87427514 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8c87427514

Comment 5 Fedora Update System 2023-05-18 13:13:23 UTC
FEDORA-2023-8c87427514 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.