I will review this by tomorrow.

( well note "tomorrow" means I will review this by 10/28   10:00EST)

Well, currently I cannot check this package (adesklets) with
installing this because there is a issue on this package which
prevents me from doing so.

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint.
  - Well, please check your packages by rpmlint (in Fedora Extras)
    before you submit your packages.
    rpmlint is not silent.
----------------------------------------------------------------
E: adesklets info-dir-file /usr/share/info/dir
   Existence of /usr/share/info/dir breaks all info information
   in other packages. Please remove this.

W: adesklets hidden-file-or-dir \
     
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
W: adesklets perl-temp-file \
     
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
   These files are not necessary.

E: adesklets non-standard-executable-perm \
      /usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl 0555
   Please explain why the permission of this file is not 0755.

W: adesklets file-not-utf8 /usr/share/info/adesklets_fr.info.gz
   This file is encoded in ISO-8859-1 (perhaps). Change the encoding to UTF-8.

W: adesklets perl-temp-file
/usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
   This file is unneeded.

W: adesklets spurious-bracket-in-%preun
   Please use :
        if [ $1 = 0 ]; then

W: adesklets mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
   For indentation, please use spaces or tabs, not both.
-----------------------------------------------------------------------

* Requires:
  - python-abi
    This is not required as described in
http://fedoraproject.org/wiki/Packaging/Python .

* BuildRequires:
  - The results of rpmbuild and mockbuild differs.
------------------------------------------------------------------------
[tasaka1@localhost i386]$ rpm -qp --requires adesklets-0.6.1-3.i386.rpm | sort >
1.txt
[tasaka1@localhost i386]$ rpm -qp --requires adesklets-0.6.1-3.fc7.i386.rpm |
sort > 2.txt
[tasaka1@localhost i386]$ diff -u 1.txt 2.txt 
--- 1.txt       2006-10-28 21:06:43.000000000 +0900
+++ 2.txt       2006-10-28 21:06:46.000000000 +0900
@@ -6,7 +6,6 @@
 /usr/bin/env  
 /usr/bin/perl  
 libImlib2.so.1  
-libX11.so.6  
 libc.so.6  
 libc.so.6(GLIBC_2.0)
-----------------------------------------------------------------------
Mockbuild buildlog says:
-----------------------------------------------------------------------
.........
checking for X... no
.........
configure: WARNING:
-----------------------------------------------------
you choosed to perform an `X Window less' build -
which means you will eventually end up with
a strictly command line program free of all
dependencies on xlib. If it is not what you intended
please reconfigure. For this to work you do need first
to configure your Imlib2 incantation for not using
X Window itself.
-----------------------------------------------------
................
-----------------------------------------------------------------------
   - Check the dependency for X related packages.

* Duplication of system libraries
   - /usr/share/adesklets/Vera.ttf
     Vera.ttf is included in bitstream-vera-fonts rpm and should not be 
     included in this package.

* Desktop files
  - This is GUI application and a appropriate application file should
    be installed.

* File and Directory Ownership
   - This package owns the following directories. This should not.
   /usr/lib/perl5/5.8.8
   /usr/lib/perl5/5.8.8/i386-linux-thread-multi
   /usr/lib/perl5/vendor_perl
   /usr/lib/perl5/vendor_perl/5.8.8
   /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
   /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto

B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
* MUST: The sources used to build the package must ...
  I recommend that you use %{name}-%{version}.tar.bz2

* MUST: A package must not contain any duplicate files in the %files listing.
  Duplicate lists found.
---------------------------------------------------------------------
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/adesklets.pm
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl
---------------------------------------------------------------------
  Please fix all.

C. Other issues I have found.
* Well, this is not a full review as I cannot install this unless the issues
  above is resolved.

ping?

Sorry for the delay. I had a busy schedule I was unable to edit the spec file.
In addition, the server went down because the host went out of busines and I
just recently got a new host. The modification will come soon.

Okay.

Note: I will be busy till this Thursday (in Japan: EST+14h) and I may not
be able to check your srpm by that day.

Understood. I will take time to rework the spec file.

Now I am alive and I will check the new srpm when
you upload it.

ping?

Again ping?

Back. One of problem is the lack of familiarity with the perl module used on
adesklets. Currently reading
http://fedoraproject.org/wiki/PackagingTips/Perl

Again ping?

Again...

Well, actually more than one month is passed since I received
a comment from you.

I will close this bug if I cannot receive a comment from
you within a week.

Already a month. I haven;t had access to the system to resume the work being
busy at the job. I will resume the package development.

Well, please upload a modified package, please!!

Actually no progress is made since my comment 3, which
is October of the last year.

http://www.thefinalzone.com/RPMS/adeskets.spec
http://www.thefinalzone.com/RPMS/adeskets-0.6.1-4.src.rpm
Unfortunately, I am unable to remove
/usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
I need to see what mistake I made so I can fix them.

Well,

-----------------------------------------------------
Not Found
The requested URL /RPMS/adeskets-0.6.1-4.src.rpm was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an
ErrorDocument to handle the request. 
-----------------------------------------------------

A typo from my part
http://www.thefinalzone.com/RPMS/adesklets-0.6.1-4.src.rpm

Umm... 0.6.1-4 still has a lot of issues to be fixed
I only checked packaging issues and I have not installed
this yet.

* The following issue:

> Unfortunately, I am unable to remove
> /usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
> I need to see what mistake I made so I can fix them.
  - First of all, the place you wrote "rm -rf" is wrong.
    (Why is this before "make install")?
  - And check the macro {perl_vendorlib} actually returns.
-------------------------------------------------------------
[tasaka1@localhost adesklets]$ rpm --eval %perl_vendorlib
/usr/lib/perl5/vendor_perl/5.8.8
-------------------------------------------------------------

* BuildRequires
  - desktop-file-install requires "desktop-file-utils" for
    BuildRequires.
  - Still X related packages are missing from BuildRequires.
-------------------------------------------------------------
checking for fontconfig... no <- HERE
configure: WARNING:
-----------------------------------------------------
`fontconfig' was not found on your system.
Although `adesklets' will work anyway system-wide
automatic font detection will not occur:
it is therefore quite possible that only the
default font provided with the package will display.
-----------------------------------------------------
checking for fork... yes
checking for X... no <- HERE
-------------------------------------------------------------
    and
-----------------------------------------------------
you choosed to perform an `X Window less' build -
which means you will eventually end up with
a strictly command line program free of all
dependencies on xlib. If it is not what you intended
please reconfigure. For this to work you do need first
to configure your Imlib2 incantation for not using
X Window itself.
-----------------------------------------------------

* Macros
  - The following macros are not defined.
-----------------------------------------------------
[tasaka1@localhost i386]$ rpm --eval %_install_info
%_install_info
-----------------------------------------------------
  - And check "Texinfo" section of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
      * Requirement for info package is missing
      * post does not the value 0 as $1
      * This is non-safe on non-docs install.
http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00017.html

* Perl temp file
-----------------------------------------------------
W: adesklets hidden-file-or-dir
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
W: adesklets perl-temp-file
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
-----------------------------------------------------
  - Usually .packlist files should be removed.

* Permission
-----------------------------------------------------
E: adesklets non-standard-executable-perm
/usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl 0555
-----------------------------------------------------
  - Why should this file should have 0555 (not 0755 or 0644) permission?

* Encodings
-----------------------------------------------------
W: adesklets file-not-utf8 /usr/share/info/adesklets_fr.info.gz
-----------------------------------------------------
   Please change the encodings to UTF-8.

* Desktop files
  - Categories are not right.
-----------------------------------------------------
Categories=User Interface;Desktop;
-----------------------------------------------------
    while desktop-file-validate complains:
-----------------------------------------------------
warning: Categories values must be one of 
"AudioVideo", "Audio", "Video", "Development", "Education", 
"Game", "Graphics", "Network", "Office", "Settings", "System", 
"Utility", "Building", "Debugger", "IDE", "GUIDesigner", 
"Profiling", "RevisionControl", "Translation", "Calendar", 
"ContactManagement", "Database", "Dictionary", "Chart", "Email", 
"Finance", "FlowChart", "PDA", "ProjectManagement", "Presentation", 
"Spreadsheet", "WordProcessor", "2DGraphics", "VectorGraphics", 
"RasterGraphics", "3DGraphics", "Scanning", "OCR", "Photography", 
"Viewer", "DesktopSettings", "HardwareSettings", "PackageManager", 
"Dialup", "InstantMessaging", "IRCClient", "FileTransfer", 
"HamRadio", "News", "P2P", "RemoteAccess", "Telephony", 
"WebBrowser", "WebDevelopment", "Midi", "Mixer", "Sequencer", 
"Tuner", "TV", "AudioVideoEditing", "Player", "Recorder", 
"DiscBurning", "ActionGame", "AdventureGame", "ArcadeGame", 
"BoardGame", "BlocksGame", "CardGame", "KidsGame", "LogicGame", 
"RolePlaying", "Simulation", "SportsGame", "StrategyGame", "Art", 
"Construction", "Music", "Languages", "Science", "Astronomy", 
"Biology", "Chemistry", "Geology", "Math", "MedicalSoftware", 
"Physics", "Amusement", "Archiving", "Electronics", "Emulator", 
"Engineering", "FileManager", "TerminalEmulator", "Filesystem", 
"Monitor", "Security", "Accessibility", "Calculator", "Clock", 
"TextEditor", "Core", "KDE", "GNOME", "GTK", "Qt", "Motif", 
"Java", "ConsoleOnly", "Screensaver", "TrayIcon", "Applet", "Shell"
-----------------------------------------------------
    - And what is the following?
-----------------------------------------------------
Exec=twf
-----------------------------------------------------

* Again Duplication of system libraries
   - /usr/share/adesklets/Vera.ttf
     Vera.ttf is included in bitstream-vera-fonts rpm and should not be 
     included in this package.

ping?

Again?

I am going to put adesklets on hold. I am focusing on artwork development for
Fedora 7 and will get back once it is complete.

Please update the status of this bug.

ping again?

I will close this bug if no response is received from the
submitter withine ONE WEEK.

I haven't progressed on adesklets packaging. I am stuck with perl dependencies
and still unable to remove unnecessary perl files.

Well, okay. Then please upload the newest spec/srpm anyway.

I will recheck your spec/srpm again and check how I can help for it.

Would you upload new spec/srpm anyway? PLEASE!!

For some reason, I am unable to create the SRPM for adesklets with that result:



$ rpmbuild -ba rpmbuild/SPECS/adesklets.spec
error: Unable to open temp file.


RPM build errors:
    Unable to open temp file.

I am not sure what cause rpmbuild to not create a temporary file. 

Well,
* What does "df -k" show?
* If you have ~/.rpmmacros, what does it say?
* And what does "rpm --eval %_tmppath" show?

I give up reviewing this bug...

I am stooping working on this package as there is another development seeing on
http://www.redhat.com/archives/fedora-mentors-list/2007-June/msg00000.html. I
apologize for delaying packaging as I have lost interesting of packaging this
application.