Bug 2116220 - Review Request: rust-rustdct - Compute Discrete Cosine Transforms (DCT) of any size in O(nlogn) time, in pure Rust
Summary: Review Request: rust-rustdct - Compute Discrete Cosine Transforms (DCT) of an...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2116092
Blocks: 2063403
TreeView+ depends on / blocked
 
Reported: 2022-08-08 01:33 UTC by Orion Poplawski
Modified: 2022-11-15 00:22 UTC (History)
2 users (show)

Fixed In Version: rust-rustdct-0.7.1-1.fc38
Clone Of:
Environment:
Last Closed: 2022-11-15 00:22:40 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2022-08-08 01:33:16 UTC
Spec URL: https://orion.fedorapeople.org/rust-rustdct.spec
SRPM URL: https://orion.fedorapeople.org/rust-rustdct-0.7.0-1.fc37.src.rpm
Description:
Compute Discrete Cosine Transforms (DCT) of any size in O(nlogn) time, in pure
Rust.

Fedora Account System Username: orion

Comment 2 Orion Poplawski 2022-11-12 06:16:24 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94079337

Comment 3 Fabio Valentini 2022-11-12 14:09:55 UTC
You might want to trim the Summary (i.e. remove the "in pure Rust" part, for example) to make it fit into 80 characters.
Other than that, looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Gwyn Ciesla 2022-11-14 15:06:16 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustdct

Comment 5 Orion Poplawski 2022-11-15 00:22:40 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.