Bug 2118890 - Review Request: rust-wezterm-dynamic-derive - Config serialization for wezterm via dynamic json-like data values
Summary: Review Request: rust-wezterm-dynamic-derive - Config serialization for wezter...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2118892
TreeView+ depends on / blocked
 
Reported: 2022-08-17 02:11 UTC by Davide Cavalca
Modified: 2022-08-25 16:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-17 14:16:52 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-08-17 02:11:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-dynamic-derive/rust-wezterm-dynamic-derive.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-dynamic-derive/rust-wezterm-dynamic-derive-0.1.0-1.fc38.src.rpm

Description:
Config serialization for wezterm via dynamic json-like data values.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-08-17 02:11:13 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=90897826

Comment 2 Fabio Valentini 2022-08-17 09:00:54 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (included from upstream)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

You might want to replace
%license LICENSE.md
with
%license %{crate_instdir}/LICENSE.md
to reduce churn
when the next crate release will have that file, and to ensure the LICENSE.md file isn't installed into the buildroot twice.

Comment 3 Davide Cavalca 2022-08-17 11:24:59 UTC
Thanks!

$ fedpkg request-repo rust-wezterm-dynamic-derive 2118890
https://pagure.io/releng/fedora-scm-requests/issue/46480
$ fedpkg request-branch --repo rust-wezterm-dynamic-derive f37
https://pagure.io/releng/fedora-scm-requests/issue/46481
$ fedpkg request-branch --repo rust-wezterm-dynamic-derive f36
https://pagure.io/releng/fedora-scm-requests/issue/46482
$ fedpkg request-branch --repo rust-wezterm-dynamic-derive f35
https://pagure.io/releng/fedora-scm-requests/issue/46483

Comment 4 Gwyn Ciesla 2022-08-17 13:23:24 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wezterm-dynamic-derive

Comment 5 Fedora Update System 2022-08-17 14:13:40 UTC
FEDORA-2022-a415eb0bb3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a415eb0bb3

Comment 6 Fedora Update System 2022-08-17 14:16:52 UTC
FEDORA-2022-a415eb0bb3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2022-08-17 14:23:08 UTC
FEDORA-2022-f1369b862d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f1369b862d

Comment 8 Fedora Update System 2022-08-17 14:25:58 UTC
FEDORA-2022-f1369b862d has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-08-17 14:33:21 UTC
FEDORA-2022-50a7dc28c2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-50a7dc28c2

Comment 10 Fedora Update System 2022-08-17 14:42:28 UTC
FEDORA-2022-c907a953ab has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c907a953ab

Comment 11 Fedora Update System 2022-08-18 02:55:26 UTC
FEDORA-2022-50a7dc28c2 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-50a7dc28c2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-50a7dc28c2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-08-18 03:30:39 UTC
FEDORA-2022-c907a953ab has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c907a953ab \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c907a953ab

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-08-25 16:17:53 UTC
FEDORA-2022-c907a953ab has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-08-25 16:43:01 UTC
FEDORA-2022-50a7dc28c2 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.