Bug 2118892 - Review Request: rust-wezterm-dynamic - Config serialization for wezterm via dynamic json-like data values
Summary: Review Request: rust-wezterm-dynamic - Config serialization for wezterm via d...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2118890
Blocks: 1984198 2105859
TreeView+ depends on / blocked
 
Reported: 2022-08-17 02:11 UTC by Davide Cavalca
Modified: 2022-09-12 17:44 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-02 04:57:37 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-08-17 02:11:49 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-dynamic/rust-wezterm-dynamic.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-wezterm-dynamic/rust-wezterm-dynamic-0.1.0-1.fc38.src.rpm

Description:
Config serialization for wezterm via dynamic json-like data values.

Fedora Account System Username: dcavalca

Comment 1 Fabio Valentini 2022-08-17 21:32:01 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files (manually included file from upstream for now)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches


===

You might want to replace
%license LICENSE.md
with
%license %{crate_instdir}/LICENSE.md
to ensure the license file isn't installed twice in different locations.

Comment 2 Davide Cavalca 2022-08-19 17:16:14 UTC
Thanks!

$ fedpkg request-repo rust-wezterm-dynamic 2118892
https://pagure.io/releng/fedora-scm-requests/issue/46532
$ fedpkg request-branch --repo rust-wezterm-dynamic f37
https://pagure.io/releng/fedora-scm-requests/issue/46533
$ fedpkg request-branch --repo rust-wezterm-dynamic f36
https://pagure.io/releng/fedora-scm-requests/issue/46534
$ fedpkg request-branch --repo rust-wezterm-dynamic f35
https://pagure.io/releng/fedora-scm-requests/issue/46535

Comment 3 Gwyn Ciesla 2022-08-19 18:06:28 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wezterm-dynamic

Comment 4 Fedora Update System 2022-09-02 04:55:12 UTC
FEDORA-2022-2b07810cd3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2b07810cd3

Comment 5 Fedora Update System 2022-09-02 04:57:37 UTC
FEDORA-2022-2b07810cd3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2022-09-02 05:15:05 UTC
FEDORA-2022-891be0b3db has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-891be0b3db

Comment 7 Fedora Update System 2022-09-02 05:25:00 UTC
FEDORA-2022-344a3e6a89 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-344a3e6a89

Comment 8 Fedora Update System 2022-09-02 05:36:01 UTC
FEDORA-2022-cc0a0fdb66 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cc0a0fdb66

Comment 9 Fedora Update System 2022-09-02 08:27:52 UTC
FEDORA-2022-891be0b3db has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-891be0b3db \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-891be0b3db

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-09-02 09:43:53 UTC
FEDORA-2022-344a3e6a89 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-344a3e6a89 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-344a3e6a89

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-09-02 10:44:36 UTC
FEDORA-2022-cc0a0fdb66 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-cc0a0fdb66 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cc0a0fdb66

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-09-09 11:22:49 UTC
FEDORA-2022-344a3e6a89 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-09-10 19:53:52 UTC
FEDORA-2022-cc0a0fdb66 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-09-12 17:44:51 UTC
FEDORA-2022-891be0b3db has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.