Red Hat Bugzilla – Bug 213121
Review Request: fast-user-switch-applet - a panel applet for switching users
Last modified: 2007-11-30 17:11:47 EST
The fast-user-switch-applet builds on the gdmflexiserver framework to provide
convenient management of several X sessions at the same time. We want to get this
into Core now, since it will be part of our larger plans around user switching and
console handling for FC7.
Spec file and source and binary rpms can be found here:
I've put updated srpm and spec at the same location.
spec file looks clean and shiny.
I always forget our policy of Epoch handling though. It might be a good idea to
explicitly put an epoch of 0.
should we version the buildrequires?
What's --with-gdm-config=/etc/gdm/custom.conf do? Remember for most people
custom.conf is just an empty stub file. Will that cause a problem for the applet?
is rpmlint output clean?
From looking at the code, it uses gnome-vfs to monitor the config file, and
reloads the gdm configuration if it changes. It does not read the file though,
it gets the configuration from gdm. I guess it would be better to get notification
on configuration changes from gdm, but thats just an upstream bug to file, not
something we need to sort out prior to accepting the package.
I don't think versioning the BRs would add a lot. I'd much rather rely on
version checks in the configure script. The versioned BRs in the spec file get
outdated to easily.
rpmlint output was clean when I did the packages.
The packaging guidelines don't say anything about requiring an explicit epoch,
and that would be just silly.
okie dokie, looks good then.
Buildsystem knows about it, import and build away. Please close when built for