Bug 2135034 - edflib does not support big-endian architectures
Summary: edflib does not support big-endian architectures
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: edflib
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-s390x
TreeView+ depends on / blocked
 
Reported: 2022-10-15 12:51 UTC by Ben Beasley
Modified: 2022-10-15 13:09 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-10-15 13:09:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab Teuniz EDFlib issues 9 0 None closed Support big-endian architectures 2022-10-15 12:51:57 UTC

Description Ben Beasley 2022-10-15 12:51:58 UTC
The edflib package does not support big-endian architectures, which impacts s390x.

This was brought to upstream’s attention in https://gitlab.com/Teuniz/EDFlib/-/issues/9, and a nontrivial patch was offered in https://gitlab.com/Teuniz/EDFlib/-/merge_requests/1. Upstream declined the patch, citing concerns about performance, testing, and necessity.

Since then, the Fedora package has carried the declined PR as a downstream patch for s390x only.

With upstream release 1.23, “non-support” of big-endian architectures is explicitly documented, and endianness is checked at runtime: https://gitlab.com/Teuniz/EDFlib/-/commit/b931e24744bd9e1e3161e20754ac23484e1e2452

Therefore, beginning with version 1.23 in Rawhide/F38, the Fedora package will drop the downstream patch and stop building edflib for s390x. Since edflib is currently a leaf package, there will be no impact to other Fedora packages.

Note that edflib should not be confused with python-pyedflib, which uses a bundled fork of edflib and which has never supported s390x (bug 2027046).

Comment 1 Ben Beasley 2022-10-15 13:09:49 UTC
Closing as WONTFIX since this is an upstream design decision now baked into the API and error codes.


Note You need to log in before you can comment on or make changes to this bug.