Spec URL: https://decathorpe.fedorapeople.org/rust-io-uring.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-io-uring-0.5.8-1.fc37.src.rpm Description: Low-level `io_uring` userspace interface for Rust. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=93525056 Note: The broken tests on i686 should be harmess (looks like they are caused by hardcoded architecture-specific struct layout / alignment in bindgen tests), but the code itself should be fine, since it is automatically generated from the host linux kernel headers during the build process.
New scratch build that didn't fail with koji issues: https://koji.fedoraproject.org/koji/taskinfo?taskID=93525590
Do Rust packages go through the usual Fedora review process? If that is so I will review this one - please just assign it to me.
Yup, they go through the normal review process, the review is just often really simple - because most of the packaging files can be automatically generated. For example, here's a review I recently did: https://bugzilla.redhat.com/show_bug.cgi?id=2118891#c4 Things that are interesting to the review process are usually: - Is the license acceptable and are all necessary license files included (i.e. MIT or Apache-2.0 require license files)? - Does it build *and* install without errors (especially off-by-default feature subpackages)? - If running the test suite or individual tests are disabled, is the reason for that documented? - If there are any downstream patches, are the reasons for them documented? - Have PRs been filed for "upstreamable" patches? So, basically, there need to be justifications for any manual edits to the automatically generated spec. (If there's something the packager needs to fix in the automatically generated spec *because the generated spec is wrong*, then we consider that a bug in rust2rpm that should be filed there, so it can be fixed for *all packages*.) Hope that makes sense, and thanks for the review! I've been interested in packaging the io-uring support for a while, this has finally pushed me to work on it again, and it turns out, the crate now works on all architectures. :)
The package was generated by a trusted maintainer using rust2rpm so I'm going to do a reduced review. Upstream package: https://github.com/tokio-rs/io-uring The latest version is packaged (0.5.8). The license: field is correct, and matches the upstream package. The license is acceptable for Fedora. There are two downstream patches concerned with making sure bindings get unconditionally regenerated. There doesn't seem to be any reason why these should need to go upstream. The spec file is legible and largely generated. The scratch build shows that the package builds on Koji and the subpackages and requires/provides look sensible. I built and installed the package and used it to build libblkio, which actually failed (since libblkio seems to require 0.5.6, not 0.5.8), but that's something for us to solve with the libblkio review (bug 2124697).
*** Package is APPROVED for Fedora by rjones ***
Awesome, thanks for the fast review! I'll post links to the other bugs once they are ready. $ fedpkg request-repo rust-io-uring 2138378 https://pagure.io/releng/fedora-scm-requests/issue/48473 $ fedpkg request-branch --repo rust-io-uring f37 https://pagure.io/releng/fedora-scm-requests/issue/48474 $ fedpkg request-branch --repo rust-io-uring f36 https://pagure.io/releng/fedora-scm-requests/issue/48475 $ fedpkg request-branch --repo rust-io-uring f35 https://pagure.io/releng/fedora-scm-requests/issue/48476
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-io-uring
Built and submitted: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1ace837d96 https://bodhi.fedoraproject.org/updates/FEDORA-2022-08f14b1ae9 https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f0c085cfd https://bodhi.fedoraproject.org/updates/FEDORA-2022-d1c0a763b4