Hide Forgot
Description of problem: In the environment of LANG=ja_JP.eucJP, ``Password''(in fact Japanese characters) is written in garbled characters at the password dialog box for unlocking screen. Version-Release number of selected component (if applicable): gnome-screensaver-2.16.1-2.fc6 How reproducible: always Steps to Reproduce: for example 1. $ gnome-screensaver-command --exit 2. $ LANG=ja_JP.eucJP gnome-screensaver 3. $ gnome-screensaver-command --lock Actual results: please see this picture http://naka-e.no-ip.com/tmp/garbled.png Expected results: http://naka-e.no-ip.com/tmp/utf8.png (if LANG=ja_JP.UTF-8, it has no problem) Additional info:
Hi nakai: what if you set LANG=ja_JP.utf8 ?
(In reply to comment #1) > Hi nakai: > > what if you set LANG=ja_JP.utf8 ? Excuse me. You are telling me to try LANG=ja_JP.utf8 instead of LANG=ja_JP.UTF-8 ? I tried LANG=ja_JP.utf8, it was same as LANG=ja_JP.UTF-8.
Looks like we're missing a g_locale_to_utf8 call.
Hi nakai, I was asking you to try ja_JP.utf8 (or ja_JP.UTF-8, it doesn't matter) instead of ja_JP.eucJP. I am just trying to confirm that this problem is because we aren't converting the pam messages from the user's encoding to the encoding gtk+ expects internally (which is utf8) Can you reconfirm that LANG=ja_JP.utf8 *doesn't* work either? Because if a utf8 locale doesn't work then this bug might not be as straight forward as it seems.
(In reply to comment #4) LANG=ja_JP.utf8 works as expected. I captured this picture (in ``Expected results'') as ja_JP.UTF-8. http://naka-e.no-ip.com/tmp/utf8.png
Oh I see. Sorry for the confusion nakai. Somehow I didn't read the last part of your initial comment.
Created attachment 140784 [details] covert pam messages from users locale to utf8 I think something like the above should fix things up. I'll push this patch into updates-testing so you can try it, nakai. Jon, does this look sane to you?
The upstream patch doesn't fix it?
ahh, I didn't notice you already fixed this upstream! Okay, so we'll just roll your fix in with the next 2.16 release we push to updates.
Oh, I need to add your check for when it fails... I'll add that bit now. off topic: do you want to get the auth async stuff upstream? I can't remember if I have a patch for that or if you think it is ready. Thanks.
Yea I definitely want to get it upstream. I gave you a patch at one point, I think, but in a downstream report not an upstream one. I had to disable it in rawhide because it was causing issues with gnome-screensaver 2.17 (bug 212194) that I haven't had time to look into yet, so you might want to wait until I get that sorted out.
Yeah it is way better to fix this in gs-auth so I've reverted my patch and applied one based on yours with tiny fixes for c99ism, casting, and indentation. Thanks for the sanity check! I've attached the patch that was committed to the gnome bug. Sounds good about the other issue. Let me know. Thanks Ray.
> I'll push this patch > into updates-testing so you can try it, nakai. Now, is it available? I can't find it in http://download.fedora.redhat.com/pub/fedora/linux/core/updates/testing/6/i386/ By the way, I could make sure that this problem was fixed by patching Ray's one into gnome-screensaver-2.16.1-2.fc6.src.rpm (and rebuilding it). However, I can't patch Jon's. ----------- $ cd gnome-screensaver-2.16.1/ $ patch -p0 < patchfile patching file ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file ChangeLog.rej patching file src/gnome-screensaver-dialog.c Hunk #1 FAILED at 207. Hunk #2 FAILED at 255. 2 out of 2 hunks FAILED -- saving rejects to file src/gnome-screensaver-dialog.c.rej patching file src/gs-auth-pam.c ----------- How to patch?
Hey nakai, So I dropped the ball a bit and didn't end up building the package. it's going through the build system now, but it's currently frozen because a tree compose is underway. Jons patch likely doesn't apply because of the async auth stuff he mentioned in comment 10. If you want, you can comment out those patches ( %patch2 -p1 -b .better-pam-integration %patch3 -p1 -b .securitytoken ) you might have to trim out the changelog part of his patch. Alternatively, you can wait until tomorrow and the update should be in testing
I see. I will wait. thanks.
Hi, We no longer support Fedora Core 6 and I am currently trying to get my open bug count down to a more manageable state. I'm going to close this bug as WONTFIX. If this issue is still a concern for you, would you mind trying to reproduce on a supported version of Fedora and reopening? (this is a mass message)