Spec URL: http://people.atrpms.net/~hdegoede/Ri-li.spec SRPM URL: http://people.atrpms.net/~hdegoede/Ri-li-2.0.0-1.fc7.src.rpm Description: You drive a toy wood engine in many levels and you must collect all the coaches to win. Full-featured: 18 languages, Colorful animated wood engine, 50 levels, 3 beautiful music tracks and many sound effects.
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream e6dfa35616f5c84eb14ff82517cea796 Ri-li-2.0.0.tar.bz2 - package successfully compiles and builds on FC6 x86_64 - all build dependencies are listed in BR - package does not use locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation files - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no need for devel subpackage - no .la files - contains proper .desktop file - package does not own files or directories owned by other packages APPROVED ==== SHOULD ==== - Remove SDL-devel from BR, SDL_Mixer-devel should pick it up
(In reply to comment #1) > > ==== SHOULD ==== > - Remove SDL-devel from BR, SDL_Mixer-devel should pick it up > Done. Thanks for the review, imported and build, closing.