Bug 2155240 - python-pycdio fails to build with Python 3.12: AttributeError: 'CDTextTests' object has no attribute 'assertEquals'.
Summary: python-pycdio fails to build with Python 3.12: AttributeError: 'CDTextTests' ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pycdio
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.12
TreeView+ depends on / blocked
 
Reported: 2022-12-20 13:49 UTC by Tomáš Hrnčiar
Modified: 2023-04-01 19:49 UTC (History)
3 users (show)

Fixed In Version: 2.1.0-10
Clone Of:
Environment:
Last Closed: 2023-04-01 19:49:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-12-20 13:49:43 UTC
python-pycdio fails to build with Python 3.12.0a3.

======================================================================
ERROR: Test getting and setting CDText
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pycdio-2.1.0/test/test-cdtext.py", line 47, in test_get_set
    self.assertEquals(text.get(pycdio.CDTEXT_FIELD_PERFORMER, 0), 'Performer')
    ^^^^^^^^^^^^^^^^^
AttributeError: 'CDTextTests' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: Test keywords
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pycdio-2.1.0/test/test-cdtext.py", line 33, in test_keyword
    self.assertEquals(pycdio.cdtext_field2str(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'CDTextTests' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?


Removed many old deprecated unittest features:

    - A number of TestCase method aliases:

    | Deprecated alias      |  Method Name           | Deprecated in |
    +-----------------------|------------------------|---------------+
    | failUnless            | assertTrue()           |      3.1      |
    | failIf                | assertFalse()          |      3.1      |
    | failUnlessEqual       | assertEqual()          |      3.1      |
    | failIfEqual           | assertNotEqual()       |      3.1      |
    | failUnlessAlmostEqual | assertAlmostEqual()    |      3.1      |
    | failIfAlmostEqual     | assertNotAlmostEqual() |      3.1      |
    | failUnlessRaises      | assertRaises()         |      3.1      |
    | assert_               | assertTrue()           |      3.2      |
    | assertEquals          | assertEqual()          |      3.2      |
    | assertNotEquals       | assertNotEqual()       |      3.2      |
    | assertAlmostEquals    | assertAlmostEqual()    |      3.2      |
    | assertNotAlmostEquals | assertNotAlmostEqual() |      3.2      |
    | assertRegexpMatches   | assertRegex()          |      3.2      |
    | assertRaisesRegexp    | assertRaisesRegex()    |      3.2      |
    | assertNotRegexpMatches| assertNotRegex()       |      3.5      |
    +-----------------------|------------------------|---------------+

    You can use https://github.com/isidentical/teyit to automatically modernise your unit tests.

    - Undocumented and broken TestCase method assertDictContainsSubset (deprecated in Python 3.2).

    - Undocumented TestLoader.loadTestsFromModule parameter use_load_tests (deprecated and ignored since Python 3.2).

    - An alias of the TextTestResult class: _TextTestResult (deprecated in Python
3.2).

(Contributed by Serhiy Storchaka in bpo-45162.)
https://bugs.python.org/issue?@action=redirect&bpo=45162



https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05129464-python-pycdio/

For all our attempts to build python-pycdio with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-pycdio/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2023-02-07 15:03:28 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Miro Hrončok 2023-03-31 17:17:46 UTC
Raising severity because this blocks pungi and hence @critical-path-compose.

Comment 3 Miro Hrončok 2023-03-31 17:26:43 UTC
Downstream-only fix here: https://src.fedoraproject.org/rpms/python-pycdio/pull-request/1

Comment 4 Kevin Fenzi 2023-04-01 17:59:43 UTC
Merged it. Let me know if you need a new build.

Comment 5 Miro Hrončok 2023-04-01 19:49:07 UTC
Thanks. No need.


Note You need to log in before you can comment on or make changes to this bug.