Bug 2155488 - python-liblarch fails to build with Python 3.12: AttributeError: 'TestLibLarch' object has no attribute 'assert_'.
Summary: python-liblarch fails to build with Python 3.12: AttributeError: 'TestLibLarc...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: python-liblarch
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.12
TreeView+ depends on / blocked
 
Reported: 2022-12-21 10:51 UTC by Tomáš Hrnčiar
Modified: 2024-05-21 14:24 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-05-21 14:24:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-12-21 10:51:31 UTC
python-liblarch fails to build with Python 3.12.0a3.


=================================== FAILURES ===================================
_________________________ TestLibLarch.test_green_leaf _________________________

self = <tests.test_liblarch.TestLibLarch testMethod=test_green_leaf>

    def test_green_leaf(self):
        """We apply a green and leaf filter then we remove the green
        from one of the leaf node and the green parent should be displayed"""
        def green_leaf(node):
            # We return False if one child is green
            for c in node.get_children():
                cnode = self.tree.get_node(c)
                if cnode.has_color('green'):
                    return False
            return node.has_color('green')
        self.tree.add_filter('green_leaf', green_leaf)
        view = self.tree.get_viewtree(refresh=False)
        test = TreeTester(view)
        view.apply_filter('green_leaf')
        self.assertEqual(1, view.get_n_nodes())
        nid = view.get_node_for_path(('14', ))
        # Now, we add a new node
        node = DummyNode('temp')
        node.add_color('green')
        self.tree.add_node(node, parent_id='14')
        self.assertEqual(1, view.get_n_nodes())
        nid = view.get_node_for_path(('temp', ))
        self.assertEqual('temp', nid)
        # Only one node should be there
        self.assertEqual(1, view.get_n_nodes())
        # 14 should not be there
        self.assertFalse(view.is_displayed('14'))
        # Now we remove 'temp' from the tree
        node.remove_color('green')
        self.assertEqual(1, view.get_n_nodes())
>       self.assert_(view.is_displayed('14'))
E       AttributeError: 'TestLibLarch' object has no attribute 'assert_'. Did you mean: 'assertIn'?

tests/test_liblarch.py:1186: AttributeError
________________________ TestLibLarch.test_leaf_filter _________________________

self = <tests.test_liblarch.TestLibLarch testMethod=test_leaf_filter>

    def test_leaf_filter(self):
        view = self.tree.get_viewtree(refresh=False)
        test = TreeTester(view)
        """Test filtering to show only the leaf nodes.
    
        When the 'leaf' filter is applied and a child added to a node,
        the parent node should not be present in the results.
        """
        view.apply_filter('leaf')
        total = self.red_nodes + self.blue_nodes
        self.assertEqual(total, view.get_n_nodes())
        view.apply_filter('green')
        self.assertEqual(1, view.get_n_nodes())
        nid = view.get_node_for_path(('14', ))
        # Now, we add a new node
        node = DummyNode('temp')
        node.add_color('green')
        self.tree.add_node(node, parent_id='14')
        self.assertEqual(1, view.get_n_nodes())
        nid = view.get_node_for_path(('temp', ))
        self.assertEqual('temp', nid)
        # Only one node should be there
        self.assertEqual(1, view.get_n_nodes())
        # 14 should not be there
        self.assertFalse(view.is_displayed('14'))
        # Now we remove 'temp' from the tree
        self.tree.del_node('temp')
        self.assertEqual(1, view.get_n_nodes())
>       self.assert_(view.is_displayed('14'))
E       AttributeError: 'TestLibLarch' object has no attribute 'assert_'. Did you mean: 'assertIn'?

tests/test_liblarch.py:1153: AttributeError
_____________________ TestLibLarch.test_node_count_update ______________________

self = <tests.test_liblarch.TestLibLarch testMethod=test_node_count_update>

    def test_node_count_update(self):
        """this is for the @t @ta @tag bug"""
        def filter_func(node):
            # we display a color in tagtree only if
            # this color has at least one node in self.tree
            color = node.get_id()
            viewcount = self.tree.get_viewcount(name=color, refresh=True)
            count = viewcount.get_n_nodes()
            return count > 0
        # self.tree is where we will store "tasks" (here colors)
        # the main tree will be the tag tree.
        tagtree = Tree()
        blue_tag = CountNode("blue", self.tree)
        tagtree.add_node(blue_tag)
        green_tag = CountNode("green", self.tree)
        tagtree.add_node(green_tag)
        red_tag = CountNode("red", self.tree)
        tagtree.add_node(red_tag)
        tagtree.add_filter("color_exists", filter_func)
        view = tagtree.get_viewtree()
        view.apply_filter("color_exists")
>       self.assert_(view.is_displayed("red"))
E       AttributeError: 'TestLibLarch' object has no attribute 'assert_'. Did you mean: 'assertIn'?

Removed many old deprecated unittest features:

    - A number of TestCase method aliases:

    | Deprecated alias      |  Method Name           | Deprecated in |
    +-----------------------|------------------------|---------------+
    | failUnless            | assertTrue()           |      3.1      |
    | failIf                | assertFalse()          |      3.1      |
    | failUnlessEqual       | assertEqual()          |      3.1      |
    | failIfEqual           | assertNotEqual()       |      3.1      |
    | failUnlessAlmostEqual | assertAlmostEqual()    |      3.1      |
    | failIfAlmostEqual     | assertNotAlmostEqual() |      3.1      |
    | failUnlessRaises      | assertRaises()         |      3.1      |
    | assert_               | assertTrue()           |      3.2      |
    | assertEquals          | assertEqual()          |      3.2      |
    | assertNotEquals       | assertNotEqual()       |      3.2      |
    | assertAlmostEquals    | assertAlmostEqual()    |      3.2      |
    | assertNotAlmostEquals | assertNotAlmostEqual() |      3.2      |
    | assertRegexpMatches   | assertRegex()          |      3.2      |
    | assertRaisesRegexp    | assertRaisesRegex()    |      3.2      |
    | assertNotRegexpMatches| assertNotRegex()       |      3.5      |
    +-----------------------|------------------------|---------------+

    You can use https://github.com/isidentical/teyit to automatically modernise your unit tests.

    - Undocumented and broken TestCase method assertDictContainsSubset (deprecated in Python 3.2).

    - Undocumented TestLoader.loadTestsFromModule parameter use_load_tests (deprecated and ignored since Python 3.2).

    - An alias of the TextTestResult class: _TextTestResult (deprecated in Python
3.2).

(Contributed by Serhiy Storchaka in bpo-45162.)
https://bugs.python.org/issue?@action=redirect&bpo=45162



https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05133259-python-liblarch/

For all our attempts to build python-liblarch with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-liblarch/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2023-02-07 15:03:59 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Fedora Admin user for bugzilla script actions 2023-09-05 00:50:30 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 3 Aoife Moloney 2024-05-07 15:54:21 UTC
This message is a reminder that Fedora Linux 38 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 38 on 2024-05-21.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '38'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 38 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 Aoife Moloney 2024-05-21 14:24:27 UTC
Fedora Linux 38 entered end-of-life (EOL) status on 2024-05-21.

Fedora Linux 38 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.