Spec URL: https://salimma.fedorapeople.org/rust-libmimalloc-sys.spec SRPM URL: https://salimma.fedorapeople.org/rust-libmimalloc-sys-0.1.28-1.fc37.src.rpm Description: Sys crate wrapping the mimalloc allocator. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/5200801 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158276-rust-libmimalloc-sys/fedora-rawhide-x86_64/05200801-rust-libmimalloc-sys/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Please double check that the license file included is correct, it looks like it's the one for the bundled C library?
Updated the spec, and filed a PR upstream to include the license text. Both texts are now included: RPM build warnings: File listed twice: /usr/share/cargo/registry/libmimalloc-sys-0.1.28/LICENSE.txt File listed twice: /usr/share/cargo/registry/libmimalloc-sys-0.1.28/c_src/mimalloc/LICENSE
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED.
Thanks! fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 4s ⬢ [fedora-toolbox:37] ❯ set -gx C libmimalloc-sys fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) ⬢ [fedora-toolbox:37] ❯ set -gx B 2158276 fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) ⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B https://pagure.io/releng/fedora-scm-requests/issue/50260 fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 4s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9 https://pagure.io/releng/fedora-scm-requests/issue/50261 fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 6s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases https://pagure.io/releng/fedora-scm-requests/issue/50262 https://pagure.io/releng/fedora-scm-requests/issue/50263
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libmimalloc-sys
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.