Bug 2158280 - Review Request: rust-mimalloc - Performance and security oriented drop-in allocator
Summary: Review Request: rust-mimalloc - Performance and security oriented drop-in all...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2158276
Blocks: ITP-rust-difftastic
TreeView+ depends on / blocked
 
Reported: 2023-01-04 22:20 UTC by Michel Alexandre Salim
Modified: 2023-01-10 02:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-08 01:20:23 UTC
Type: ---
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Alexandre Salim 2023-01-04 22:20:57 UTC
Spec URL: https://salimma.fedorapeople.org/rust-mimalloc.spec
SRPM URL: https://salimma.fedorapeople.org/rust-mimalloc-0.1.32-1.fc37.src.rpm

Description:
Performance and security oriented drop-in allocator.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-01-04 22:24:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5200813
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2158280-rust-mimalloc/fedora-rawhide-x86_64/05200813-rust-mimalloc/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 2 Davide Cavalca 2023-01-04 23:03:46 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Michel Alexandre Salim 2023-01-04 23:14:43 UTC
Thanks!

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 5s 
⬢ [fedora-toolbox:37] ❯ set -gx C mimalloc

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) 
⬢ [fedora-toolbox:37] ❯ set -gx B 2158280

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) 
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50256

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 3s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50257
https://pagure.io/releng/fedora-scm-requests/issue/50258

fedora/pkgs-sig-rust/difftastic via 🐍 v3.11.0 (.venv311) took 6s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50259

Comment 4 Gwyn Ciesla 2023-01-05 15:38:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mimalloc

Comment 5 Fedora Update System 2023-01-06 19:21:30 UTC
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

Comment 6 Fedora Update System 2023-01-07 01:28:51 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-01-07 03:11:44 UTC
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

Comment 8 Fedora Update System 2023-01-07 03:13:13 UTC
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

Comment 9 Fedora Update System 2023-01-08 01:20:23 UTC
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-01-08 01:28:59 UTC
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-01-10 02:17:33 UTC
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.