Spec URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05206741-kvmd/kvmd.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05206741-kvmd/kvmd-3.191-1.fc38.src.rpm There are some points that worth discuss, your opinions are appreciated. 1. The original author builds a package for each possible hardware combination https://github.com/pikvm/kvmd/blob/1b10766071ad96dcd5e788a8b2fb6e178e44e20c/PKGBUILD#L189 Do we also want this in fedora? Currently the default config files are located at %{_datadir} 2. The kvmd binary has to read/write /dev/gpiochip* sometimes (it is 660 on my system). So the kvmd* user has been added to the gpio group. 3. The upstream has some hardcoded code to access device_tree and vcgencmd, which may only exists in rpi distribution. So I copied some mock script (fake) to be used.
Reworked Spec: Spec URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05207872-kvmd/kvmd.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05207872-kvmd/kvmd-3.191-2.fc38.src.rpm Description: The kvmd daemon is used to make the server running this service capable of being as an out of band KVM(Keyboard, Video, Mouse) machine over the network. Fedora Account System Username: tao-j
Copr build: https://copr.fedorainfracloud.org/coprs/build/5207873 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2159144-kvmd/fedora-rawhide-x86_64/05207873-kvmd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Created attachment 1936702 [details] The .spec file difference from Copr build 5207873 to 5207874
Copr build: https://copr.fedorainfracloud.org/coprs/build/5207874 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2159144-kvmd/fedora-rawhide-x86_64/05207874-kvmd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-43-x86_64/10299433-kvmd/kvmd.spec https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-43-x86_64/10299433-kvmd/kvmd-4.163-1.fc43.src.rpm reopen to resume review
Created attachment 2136290 [details] The .spec file difference from Copr build 5207874 to 10299439
Copr build: https://copr.fedorainfracloud.org/coprs/build/10299439 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2159144-kvmd/fedora-rawhide-x86_64/10299439-kvmd/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.