Bug 2456331 - Review Request: pyserial-asyncio - Python asyncio support for pyserial
Summary: Review Request: pyserial-asyncio - Python asyncio support for pyserial
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 43
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Petr Menšík
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/pyserial/pyserial-...
Whiteboard:
Depends On:
Blocks: 2159144
TreeView+ depends on / blocked
 
Reported: 2026-04-08 01:38 UTC by Tao Jin
Modified: 2026-04-29 03:06 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
pemensik: fedora-review+


Attachments (Terms of Use)

Description Tao Jin 2026-04-08 01:38:50 UTC
Just took this orphan. 


F42 branch is not blocked so pushed new spec there
https://src.fedoraproject.org/rpms/pyserial-asyncio/commits/f42

F43+ need releng unblock

Build Pass F42
https://koji.fedoraproject.org/koji/taskinfo?taskID=144171446


Reproducible: Always

Comment 2 Fedora Review Service 2026-04-08 03:09:42 UTC
The ticket summary is not in the correct format.
Expected:

    Review Request: <main package name here> - <short summary here>

Found:

    Package Review: pyserial-asyncio - Python asyncio support for pyserial

As a consequence, the package name cannot be parsed and submitted to
be automatically build. Please modify the ticket summary and trigger a
build by typing [fedora-review-service-build].


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2026-04-08 03:20:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10299416
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2456331-pyserial-asyncio/fedora-rawhide-x86_64/10299416-pyserial-asyncio/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/pyserial-asyncio
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Tao Jin 2026-04-08 03:22:31 UTC
this is an old orphaned pkg that >8weeks need review. Thanks for the help.

Comment 6 Petr Menšík 2026-04-16 22:14:48 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/pyserial-asyncio
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License". 18 files have
     unknown license. Detailed output of licensecheck in
     /home/pihhan/fedora/2456331-pyserial-asyncio/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.14,
     /usr/lib/python3.14/site-packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 843 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-pyserial-asyncio
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-pyserial-asyncio-0.6-15.fc45.noarch.rpm
          python-pyserial-asyncio-doc-0.6-15.fc45.noarch.rpm
          pyserial-asyncio-0.6-15.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpsr2m1an9')]
checks: 32, packages: 3

python-pyserial-asyncio-doc.noarch: W: summary-not-capitalized pyserial-asyncio documentation
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 11 filtered, 0 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

python-pyserial-asyncio-doc.noarch: W: summary-not-capitalized pyserial-asyncio documentation
python3-pyserial-asyncio.noarch: E: spelling-error ('Asynchronous', 'Summary(en_US) Asynchronous ')
python3-pyserial-asyncio.noarch: E: spelling-error ('extension', '%description -l en_US extension ')
python3-pyserial-asyncio.noarch: E: spelling-error ('package', '%description -l en_US package ')
python3-pyserial-asyncio.noarch: E: spelling-error ('for', '%description -l en_US for ')
python3-pyserial-asyncio.noarch: E: spelling-error ('the', '%description -l en_US the -> 7th')
python-pyserial-asyncio-doc.noarch: E: spelling-error ('documentation', 'Summary(en_US) documentation ')
python-pyserial-asyncio-doc.noarch: E: spelling-error ('Documentation', '%description -l en_US Documentation ')
python-pyserial-asyncio-doc.noarch: E: spelling-error ('for', '%description -l en_US for ')
 2 packages and 0 specfiles checked; 8 errors, 1 warnings, 7 filtered, 8 badness; has taken 0.1 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pyserial-asyncio/pyserial-asyncio-0.6.tar.gz :
  CHECKSUM(SHA256) this package     : b6032923e05e9d75ec17a5af9a98429c46d2839adfaf80604d52e0faacd7a32f
  CHECKSUM(SHA256) upstream package : b6032923e05e9d75ec17a5af9a98429c46d2839adfaf80604d52e0faacd7a32f


Requires
--------
python3-pyserial-asyncio (rpmlib, GLIBC filtered):
    python(abi)
    python3.14dist(pyserial)

python-pyserial-asyncio-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-pyserial-asyncio:
    python-pyserial-asyncio
    python3-pyserial-asyncio
    python3.14-pyserial-asyncio
    python3.14dist(pyserial-asyncio)
    python3dist(pyserial-asyncio)

python-pyserial-asyncio-doc:
    python-pyserial-asyncio-doc



Diff spec file in url and in SRPM
---------------------------------
--- /home/pihhan/fedora/2456331-pyserial-asyncio/srpm/pyserial-asyncio.spec	2026-04-17 00:06:28.120995498 +0200
+++ /home/pihhan/fedora/2456331-pyserial-asyncio/srpm-unpacked/pyserial-asyncio.spec	2026-04-08 02:00:00.000000000 +0200
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.4)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 15;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global pypi_name pyserial-asyncio
 
@@ -62,3 +72,77 @@
 
 %changelog
-%autochangelog
\ Chybí znak konce řádku na konci souboru
+## START: Generated by rpmautospec
+* Wed Apr 08 2026 Tao Jin <tao-j> - 0.6-15
+- Migrate to pyproject macros and fix tests for Python 3.14
+- Modernize spec file to use PEP 517 build process with %%pyproject_*
+  macros.
+- Use %%generate_buildrequires for dynamic dependency resolution.
+- Patch test_asyncio.py to resolve RuntimeError with
+  asyncio.get_event_loop() on Python 3.14.
+- Switch to %%autorelease and %%autochangelog.
+
+* Sat Jan 18 2025 Fedora Release Engineering <releng> - 0.6-14
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
+
+* Wed Sep 04 2024 Miroslav Suchý <msuchy> - 0.6-13
+- convert license to SPDX
+
+* Fri Jul 19 2024 Fedora Release Engineering <releng> - 0.6-12
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild
+
+* Fri Jun 07 2024 Python Maint <python-maint> - 0.6-11
+- Rebuilt for Python 3.13
+
+* Fri Jan 26 2024 Fedora Release Engineering <releng> - 0.6-10
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
+
+* Sun Jan 21 2024 Fedora Release Engineering <releng> - 0.6-9
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
+
+* Fri Jul 21 2023 Fedora Release Engineering <releng> - 0.6-8
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
+
+* Thu Jun 15 2023 Python Maint <python-maint> - 0.6-7
+- Rebuilt for Python 3.12
+
+* Fri Jan 20 2023 Fedora Release Engineering <releng> - 0.6-6
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
+
+* Fri Jul 22 2022 Fedora Release Engineering <releng> - 0.6-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
+
+* Mon Jun 13 2022 Python Maint <python-maint> - 0.6-4
+- Rebuilt for Python 3.11
+
+* Fri Jan 21 2022 Fedora Release Engineering <releng> - 0.6-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
+
+* Wed Oct 13 2021 Fabian Affolter <mail> - 0.6-2
+- UpDATE SOURCE
+
+* Wed Oct 13 2021 Fabian Affolter <mail> - 0.6-1
+- Update to latest upstream release 0.6 (closes rhbz#2009553)
+
+* Fri Jul 23 2021 Fedora Release Engineering <releng> - 0.5-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
+
+* Fri Jun 04 2021 Python Maint <python-maint> - 0.5-4
+- Rebuilt for Python 3.10
+
+* Wed Jan 27 2021 Fedora Release Engineering <releng> - 0.5-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
+
+* Wed Dec 09 2020 Fabian Affolter <mail> - 0.5-2
+- Add new BR
+
+* Wed Dec 09 2020 Fabian Affolter <mail> - 0.5-1
+- * Wed Dec 09 2020 Fabian Affolter <mail> - 0.5-1 -
+  Update to latest upstream release 0.5
+
+* Sun Sep 13 2020 Fabian Affolter <mail> - 0.4-2
+- Add source
+
+* Sun Sep 13 2020 Fabian Affolter <mail> - 0.4-1
+- * Thu Sep 10 2020 Fabian Affolter <mail> - 0.4-1 -
+  Initial package for Fedora
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2456331
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: PHP, Java, fonts, Perl, Haskell, C/C++, R, SugarActivity, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 7 Petr Menšík 2026-04-16 22:16:44 UTC
Nice, I need this for bumble dependency. Have not found anything to correct.

Please proceed to rebuilding the package :)

Comment 8 Tao Jin 2026-04-29 03:06:25 UTC
thx, f43 still block on koji otherwise f42 44 45 should have working build


Note You need to log in before you can comment on or make changes to this bug.