Spec URL: https://lbalhar.fedorapeople.org/python-pyproject-hooks.spec SRPM URL: https://lbalhar.fedorapeople.org/python-pyproject-hooks-1.0.0-1.fc37.src.rpm Description: This is a low-level library for calling build-backends in pyproject.toml-based project. It provides the basic functionality to help write tooling that generates distribution files from Python projects. Fedora Account System Username: lbalhar I'm testing this in COPR with a new version of python-build which needs this package. https://copr.fedorainfracloud.org/coprs/lbalhar/build/builds/
Copr build: https://copr.fedorainfracloud.org/coprs/build/5222459 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2160411-python-pyproject-hooks/fedora-rawhide-x86_64/05222459-python-pyproject-hooks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Thanks! There is just one blocker. The LICENSE file was not marked as such automatically, though it does get installed in dist-info. Consider an explicit `%license LICENSE` line in %files. Also, upstream uses Tox, so consider the %tox macro. You'd most likely need to sed out the flake8 dependency from dev-requirements.txt though. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [X]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Checked with the COPR build above [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 42 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-pyproject- hooks/licensecheck.txt [X]: Package contains no bundled libraries without FPC exception. Note: The bundled code that used to be in python-pep517 is gone here. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. Note: it's split off from python-pep517, Obsoletes/Provides is not applicable. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [X]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment), fixed since. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. Note: COPR build checked this, right? [-]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Reviewer should test that the package builds in mock. Note: Nah, the COPR is fine [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: LICENSE file is installed in dist-info but not marked %license. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. Note: Smoke-checked only [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. Note: This is up to to Fedora's Python packaging tools [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-pyproject-hooks-1.0.0-1.fc38.noarch.rpm python-pyproject-hooks-1.0.0-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpt08nm8bl')] checks: 31, packages: 2 python-pyproject-hooks.src: W: summary-ended-with-dot Wrappers to call pyproject.toml-based build backend hooks. python3-pyproject-hooks.noarch: W: summary-ended-with-dot Wrappers to call pyproject.toml-based build backend hooks. 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-pyproject-hooks.noarch: W: summary-ended-with-dot Wrappers to call pyproject.toml-based build backend hooks. 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pyproject_hooks/pyproject_hooks-1.0.0.tar.gz : CHECKSUM(SHA256) this package : f271b298b97f5955d53fb12b72c1fb1948c22c1a6b70b315c54cedaca0264ef5 CHECKSUM(SHA256) upstream package : f271b298b97f5955d53fb12b72c1fb1948c22c1a6b70b315c54cedaca0264ef5 Requires -------- python3-pyproject-hooks (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-pyproject-hooks: python-pyproject-hooks python3-pyproject-hooks python3.11-pyproject-hooks python3.11dist(pyproject-hooks) python3dist(pyproject-hooks) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-pyproject-hooks --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Perl, SugarActivity, R, PHP, fonts, C/C++, Haskell, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review. All points addressed.
Indeed, thanks! The latest changes are minimal, I've smoke-tested that it still builds & works. Approved!
The bugzilla has to be assigned.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyproject-hooks
https://koji.fedoraproject.org/koji/taskinfo?taskID=96241463