Updated to 10.0.1

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=e7afcd7a269bec328f19bbd24537afbbca50523c
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.0.1-1.remi.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5578993
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/05578993-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Updated to 10.0.2

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=4158e76f5376fe3c2cfa545cec7eec3bca2edc89
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.0.2-1.remi.src.rpm

Created attachment 1948367 [details]
The .spec file difference from Copr build 5578993 to 5598203

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5598203
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/05598203-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Updated to 10.1.0

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=61ae1e0b6dbc67313614a173021f790e3bd4cd89
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.0-1.remi.src.rpm

Created attachment 1957341 [details]
The .spec file difference from Copr build 5598203 to 5778366

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5778366
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/05778366-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Updated to 10.1.1

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=fd115e025895cdb4da0e6bf2c4eb47f383361d4b
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.1-1.remi.src.rpm

Created attachment 1958233 [details]
The .spec file difference from Copr build 5778366 to 5804624

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5804624
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/05804624-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Updated to 10.1.2

Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=fd115e025895cdb4da0e6bf2c4eb47f383361d4b
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.2-1.remi.src.rpm

Created attachment 1966582 [details]
The .spec file difference from Copr build 5804624 to 5950903

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5950903
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/05950903-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6093515
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2168110-php-phpunit-php-code-coverage10/fedora-rawhide-x86_64/06093515-php-phpunit-php-code-coverage10/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     BSD 3-Clause License", "MIT License". 247 files have unknown license.
     Detailed output of licensecheck in
     /home/FedoraPackaging/reviews/php-phpunit-php-code-
     coverage10/2168110-php-phpunit-php-code-coverage10/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

PHP:
[x]: Run phpci static analyze on all php files.
     Note: 6.5.5@7852058 static analyze results in
     /home/FedoraPackaging/reviews/php-phpunit-php-code-
     coverage10/2168110-php-phpunit-php-code-coverage10/phpci.log


Rpmlint
-------
Checking: php-phpunit-php-code-coverage10-10.1.2-1.fc39.noarch.rpm
          php-phpunit-php-code-coverage10-10.1.2-1.fc39.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6nolngb0')]
checks: 31, packages: 2

php-phpunit-php-code-coverage10.noarch: E: zero-length /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/css/custom.css
php-phpunit-php-code-coverage10.spec:144: W: unversioned-explicit-provides bundled(js-popper)
php-phpunit-php-code-coverage10.spec: W: invalid-url Source0: php-phpunit-php-code-coverage10-10.1.2-db1497e.tgz
php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar.html.dist
php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard.html.dist
 2 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.9 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

php-phpunit-php-code-coverage10.noarch: E: zero-length /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/css/custom.css
php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/coverage_bar.html.dist
php-phpunit-php-code-coverage10.noarch: W: files-duplicate /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard_branch.html.dist /usr/share/php/SebastianBergmann/CodeCoverage10/Report/Html/Renderer/Template/dashboard.html.dist
 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.2 s 



Requires
--------
php-phpunit-php-code-coverage10 (rpmlib, GLIBC filtered):
    (php-composer(nikic/php-parser) >= 4.15 with php-composer(nikic/php-parser) < 5)
    (php-composer(phpunit/php-file-iterator) >= 4.0 with php-composer(phpunit/php-file-iterator) < 5)
    (php-composer(phpunit/php-text-template) >= 3.0 with php-composer(phpunit/php-text-template) < 4)
    (php-composer(sebastian/code-unit-reverse-lookup) >= 3.0 with php-composer(sebastian/code-unit-reverse-lookup) < 4)
    (php-composer(sebastian/complexity) >= 3.0 with php-composer(sebastian/complexity) < 4)
    (php-composer(sebastian/environment) >= 6.0 with php-composer(sebastian/environment) < 7)
    (php-composer(sebastian/lines-of-code) >= 2.0 with php-composer(sebastian/lines-of-code) < 3)
    (php-composer(sebastian/version) >= 4.0 with php-composer(sebastian/version) < 5)
    (php-composer(theseer/tokenizer) >= 1.2.0 with php-composer(theseer/tokenizer) < 2)
    php(language)
    php-composer(fedora/autoloader)
    php-date
    php-dom
    php-json
    php-libxml
    php-pcre
    php-reflection
    php-spl
    php-tokenizer
    php-xmlwriter



Provides
--------
php-phpunit-php-code-coverage10:
    bundled(js-bootstrap)
    bundled(js-d3)
    bundled(js-jquery)
    bundled(js-nvd3)
    bundled(js-popper)
    php-composer(phpunit/php-code-coverage)
    php-phpunit-php-code-coverage10



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2168110
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, PHP, Generic
Disabled plugins: Python, Ruby, R, Perl, fonts, SugarActivity, C/C++, Java, Haskell, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Is there a version for bundled js-popper?
b) Could the bundled javascript libraries that are already be packaged used?
Unclear if there is a strong dependency on the version.
c) phpcompatinfo section, line 127, has requires that include:

Requires:       php-date
Requires:       php-pcre
Requires:       php-reflection
Requires:       php-spl
Requires:       php-tokenizer

phpcompatinfo gives these as requirements, but they 
are also listed below line 89 of the spec file.

phpcompatinfo also lists pcov, but not sure
if this is only required in a few cases.

> a) Is there a version for bundled js-popper?

Not AFAIK

> b) Could the bundled javascript libraries that are already be packaged used?
> Unclear if there is a strong dependency on the version

To be honest, javascript is the worst nightmare for packaging
No API warranty (semver)
I suffer a lot because of this in the past (was with jquery)
so I definitively prefer the "bundled everything" way for JS

> phpcompatinfo also lists pcov, but not sure

It lists xdebug and pcov with "C" for conditional, so:

Suggests:       php-xdebug
Recommends:     php-pcov

In fact one is needed to retrieve coverage information, from xdebug (better but slow), pcov (faster) or phpdbg
Missing tool will be properly reported by PHPUnit 


Spec URL: https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=87db437e0abe4374e5575e8e40762fb51f17dec4
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage10-10.1.2-2.remi.src.rpm

Thanks. Ok on JS bundling. The updated spec still twice lists:

Requires:       php-date
Requires:       php-json
Requires:       php-pcre
Requires:       php-reflection
Requires:       php-spl
Requires:       php-tokenizer

Probably the lines

# From phpcompatinfo report for version 10.0.0
Requires:       php-date
.
.
.
Requires:       php-tokenizer

can be removed after

BuildRequires:  php-theseer-tokenizer                    >= 1.2.0
%endif

add 

# Some of these from phpcompatinfo report for version 10.0.0

> The updated spec still twice lists:

Humm... can't see them...

See the removal:
https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/commit/?id=87db437e0abe4374e5575e8e40762fb51f17dec4

Have not checked srpm.  They still are there in the spec file available at:
https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/plain/php-phpunit-php-code-coverage10.spec?id=87db437e0abe4374e5575e8e40762fb51f17dec4

https://git.remirepo.net/cgit/rpms/php/sebastian/php-phpunit-php-code-coverage10.git/tree/php-phpunit-php-code-coverage10.spec

Searching for php-json in the browser shows 2 entries.

Please ensure removed when importing.

Approved.

The Pagure repository was created at https://src.fedoraproject.org/rpms/php-phpunit-php-code-coverage10

Thanks for the review

SCM requests
https://pagure.io/releng/fedora-scm-requests/issue/54109
https://pagure.io/releng/fedora-scm-requests/issue/54110

FEDORA-2023-a4cf73d652 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4cf73d652

FEDORA-2023-a4cf73d652 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4cf73d652 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4cf73d652

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-a4cf73d652 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.