Bug 2173525 - Boot order - Need to differentiate between disks and network
Summary: Boot order - Need to differentiate between disks and network
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.13.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.14.0
Assignee: Ugo Palatucci
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-27 08:07 UTC by Guohua Ouyang
Modified: 2023-11-08 14:05 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 14:05:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
boot_order_in_details (165.19 KB, image/png)
2023-03-02 02:02 UTC, Guohua Ouyang
no flags Details
boot order in add list (64.59 KB, image/png)
2023-03-02 02:03 UTC, Guohua Ouyang
no flags Details
Boot order modal w- icons to differentiate between disks and network (38.44 KB, image/png)
2023-03-27 15:45 UTC, Yifat Menchik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 1241 0 None open Bug 2173525: Disk and net icons for boot order modal 2023-04-11 08:08:01 UTC
Red Hat Issue Tracker CNV-26167 0 None None None 2023-02-27 09:01:27 UTC
Red Hat Product Errata RHSA-2023:6817 0 None None None 2023-11-08 14:05:33 UTC

Description Guohua Ouyang 2023-02-27 08:07:36 UTC
Description of problem:
Currently, the boot order items are all in plain text, no difference between them. Maybe it can have some icon to make them look different.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Hilda Stastna 2023-02-28 18:20:26 UTC
Guohua, can you, please, provide more details about this bug? Did you mean "Boot order" field displayed in the VM Details tab or something else?

Yifat, what do you think about this issue? Is that ever an issue? Do we need to distinguish between disks and network in there? If yes, then how?

Thanks in advance!

Comment 2 Guohua Ouyang 2023-02-28 23:26:05 UTC
(In reply to Hilda Stastna from comment #1)
> Guohua, can you, please, provide more details about this bug? Did you mean
> "Boot order" field displayed in the VM Details tab or something else?

Yes, I mean the "Boot order" field displayed in the VM Details tab.

> Yifat, what do you think about this issue? Is that ever an issue? Do we need
> to distinguish between disks and network in there? If yes, then how?

We should have a UX design for this, as it's not clear enough to both developer and QE.

> 
> Thanks in advance!

Comment 3 Yifat Menchik 2023-03-01 07:07:45 UTC
@gouyang would you please attach a screenshot? Thank you.

Comment 4 Guohua Ouyang 2023-03-02 02:02:17 UTC
Created attachment 1947343 [details]
boot_order_in_details

Comment 5 Guohua Ouyang 2023-03-02 02:03:03 UTC
Created attachment 1947344 [details]
boot order in add list

Comment 6 Guohua Ouyang 2023-03-02 02:24:34 UTC
If we add the distinguishes to the boot orders, maybe we should add it to all place which has the boot item list

Comment 7 Yifat Menchik 2023-03-02 09:19:32 UTC
@gouyang regarding attachment 1947344 [details]  https://bugzilla.redhat.com/attachment.cgi?id=1947344 TMO the "remove" icon should not be shown next to the dropdown. It should only appear next to a bootsource item to enable deleting it.

Comment 8 Yifat Menchik 2023-03-02 09:47:52 UTC
(In reply to Guohua Ouyang from comment #6)
> If we add the distinguishes to the boot orders, maybe we should add it to
> all place which has the boot item list

+1

Comment 9 Ugo Palatucci 2023-03-22 11:57:15 UTC
I have a pr to completely remove the 'add' dropdown.
If I'm understanding correctly, all devices, in theory, are bootable. We should show all the devices and the user should be able to just give an order.
Removing the device from that list as it is now, just remove the bootOrder property. But removing that property doesn't mean that the device is not bootable.

It's still bootable but not having that property gives just a lower priority. https://github.com/kubevirt-ui/kubevirt-plugin/pull/1167.

Comment 10 Ugo Palatucci 2023-03-22 14:46:37 UTC
@gouyang

Comment 11 Guohua Ouyang 2023-03-27 02:39:29 UTC
(In reply to Ugo Palatucci from comment #9)
> I have a pr to completely remove the 'add' dropdown.

It looks good to me and the bug 2174619 is verified.

> If I'm understanding correctly, all devices, in theory, are bootable. We
> should show all the devices and the user should be able to just give an
> order.
> Removing the device from that list as it is now, just remove the bootOrder
> property. But removing that property doesn't mean that the device is not
> bootable.
> 
> It's still bootable but not having that property gives just a lower
> priority. https://github.com/kubevirt-ui/kubevirt-plugin/pull/1167.

Comment 12 Ugo Palatucci 2023-03-27 12:17:48 UTC
@yfrimanm  hei Yifat. So is there something we can do to enhance the user experience on this modal? Some icons to differentiate the two types of devices?

Comment 13 Yifat Menchik 2023-03-27 15:45:20 UTC
Created attachment 1953962 [details]
Boot order modal w- icons to differentiate between disks and network

@upalatuc please see the Boot Order icons modal. Thanks.

Comment 14 Guohua Ouyang 2023-04-28 04:11:42 UTC
verified on kubevirt-console-plugin-rhel9-container-v4.14.0-1047

Comment 17 errata-xmlrpc 2023-11-08 14:05:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817


Note You need to log in before you can comment on or make changes to this bug.