Bug 2174144 - Review Request: rust-text-block-macros - Create a multiline string literal
Summary: Review Request: rust-text-block-macros - Create a multiline string literal
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/text-block-m...
Whiteboard:
Depends On:
Blocks: review-rust-build-fs-tree
TreeView+ depends on / blocked
 
Reported: 2023-02-28 18:03 UTC by Michel Lind
Modified: 2023-06-25 01:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-22 23:17:08 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-02-28 18:03:36 UTC
Spec URL: https://salimma.fedorapeople.org/rust-text-block-macros.spec
SRPM URL: https://salimma.fedorapeople.org/rust-text-block-macros-0.1.1-1.fc37.src.rpm

Description:
Create a multiline string literal.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-28 18:10:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5580111
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174144-rust-text-block-macros/fedora-rawhide-x86_64/05580111-rust-text-block-macros/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-01 12:49:07 UTC
There's more license text than actual code in this tiny crate, no idea why people split off projects into so many tiny pieces, but oh well ... the package looks good.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-03-02 16:55:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-text-block-macros

Comment 4 Fabio Valentini 2023-03-22 23:17:08 UTC
Package has been imported and built:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2162756

Comment 5 Fedora Update System 2023-06-16 02:26:07 UTC
FEDORA-2023-43512b4d4f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

Comment 6 Fedora Update System 2023-06-16 02:49:33 UTC
FEDORA-2023-5187dc9252 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

Comment 7 Fedora Update System 2023-06-16 02:59:55 UTC
FEDORA-EPEL-2023-49aa6f1164 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

Comment 8 Fedora Update System 2023-06-17 01:41:32 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-43512b4d4f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-06-17 02:00:56 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-06-17 02:43:00 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5187dc9252 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-06-25 00:49:58 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-06-25 00:54:04 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-06-25 01:26:09 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.