Bug 2174145 (review-rust-build-fs-tree) - Review Request: rust-build-fs-tree - Generate a filesystem tree from a macro or a YAML tree
Summary: Review Request: rust-build-fs-tree - Generate a filesystem tree from a macro ...
Keywords:
Status: CLOSED ERRATA
Alias: review-rust-build-fs-tree
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/build-fs-tree
Whiteboard:
Depends On: 2174143 2174144
Blocks: FE-DEADREVIEW review-rust-wax
TreeView+ depends on / blocked
 
Reported: 2023-02-28 18:04 UTC by Michel Lind
Modified: 2023-06-25 01:26 UTC (History)
2 users (show)

Fixed In Version: rust-build-fs-tree-0.3.1-2.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-15 16:54:28 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-02-28 18:04:02 UTC
Spec URL: https://salimma.fedorapeople.org/rust-build-fs-tree.spec
SRPM URL: https://salimma.fedorapeople.org/rust-build-fs-tree-0.3.1-1.fc37.src.rpm

Description:
Generate a filesystem tree from a macro or a YAML tree.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-28 18:07:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5580129
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174145-rust-build-fs-tree/fedora-rawhide-x86_64/05580129-rust-build-fs-tree/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-23 13:37:30 UTC
Two comments:

- v0.3.1 is no longer the latest version, please update to use a more recent release (if possible)
- It looks like you also removed some optional dependencies that are only used for building the binaries, did you use a rust2rpm config file for this? The metadata patch doesn't account for the missing subpackages.

Comment 3 Package Review 2023-05-20 00:45:29 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 4 Michel Lind 2023-05-30 15:54:10 UTC
Reopening, sorry for the delay.

Comment 5 Fabio Valentini 2023-06-13 16:14:05 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (wax depends on ^0.3)
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Two comments:

- It would be great if you could poke the project for the "wax" crate to update their dependency, v0.3.1 is quite old.
- Please make sure that the removed feature subpackages are correct. For example, I think you could remove the "structopt" subpackage as well.

Comment 6 Fedora Admin user for bugzilla script actions 2023-06-15 15:35:28 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-build-fs-tree

Comment 7 Michel Lind 2023-06-15 15:42:30 UTC
Thanks! Filed https://github.com/olson-sean-k/wax/issues/43 asking the wax developer to update. Unfortunately build-fs-tree does not include any changelog so... I'll let them figure it out. There's also been no commit to wax since last August...

Comment 8 Fedora Update System 2023-06-16 02:26:10 UTC
FEDORA-2023-43512b4d4f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

Comment 9 Fedora Update System 2023-06-16 02:49:36 UTC
FEDORA-2023-5187dc9252 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

Comment 10 Fedora Update System 2023-06-16 02:59:58 UTC
FEDORA-EPEL-2023-49aa6f1164 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

Comment 11 Fedora Update System 2023-06-17 01:41:34 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-43512b4d4f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-06-17 02:00:58 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-06-17 02:43:02 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5187dc9252 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5187dc9252

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-06-25 00:50:00 UTC
FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-06-25 00:54:06 UTC
FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2023-06-25 01:26:12 UTC
FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.