Red Hat Bugzilla – Bug 217807
Review Request: perl-Gtk2-Ex-Utils - Extra Gtk2 Utilities for working with Gnome2/Gtk2 in Perl
Last modified: 2007-11-30 17:11:50 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Utils-0.09-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Utils.spec Description: This module provides simple utility functions useful for Gnome2/Gtk2 Perl programming.
taking this for review
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. 076bb6914470fb077f7028fef0a795f8 Gtk2-Ex-Utils-0.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.
Imported and building for devel; branches requested for FC-[56]. Thanks for the review! :)