Bug 217810 - Review Request: perl-Gtk2-Ex-Dialogs - Useful tools for Gnome2/Gtk2 Perl GUI design
Summary: Review Request: perl-Gtk2-Ex-Dialogs - Useful tools for Gnome2/Gtk2 Perl GUI ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Gtk2-Ex-D...
Whiteboard:
Depends On: 217807
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-11-30 00:47 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-30 06:57:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Weyl 2006-11-30 00:47:24 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Dialogs-0.11-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Dialogs.spec

Description:
This module provides a clean, simple, quick api to generate and use common
Gtk2 dialogs, either from within a full-blown Gtk2 app or as a one-off deal
inside a non-Gtk2 perl application.

Comment 1 Parag AN(पराग) 2006-11-30 01:47:00 UTC
taking this package for review

Comment 2 Parag AN(पराग) 2006-11-30 06:39:06 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
1ad86e1b3088971835a9393c710dbbfc  Gtk2-Ex-Dialogs-0.11.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.

Comment 3 Chris Weyl 2006-11-30 06:57:57 UTC
Imported and building for devel; branching for FC-[56] requested.

Thanks for the review! :)


Note You need to log in before you can comment on or make changes to this bug.