Bug 2181038 - Review Request: rust-vm-superio - Emulation for legacy devices
Summary: Review Request: rust-vm-superio - Emulation for legacy devices
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/vm-superio
Whiteboard:
Depends On: 2141389
Blocks: 2181039
TreeView+ depends on / blocked
 
Reported: 2023-03-22 21:57 UTC by fedora.dm0
Modified: 2023-03-31 01:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-27 15:54:25 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description fedora.dm0 2023-03-22 21:57:36 UTC
Spec URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-vm-superio.spec
SRPM URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-vm-superio-0.7.0-1.fc37.src.rpm
Description: Emulation for legacy devices.
Fedora Account System Username: dm0

This is a dependency of Firecracker.  The spec is automatically generated.

Comment 1 Jakub Kadlčík 2023-03-22 22:01:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5696290
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181038-rust-vm-superio/fedora-rawhide-x86_64/05696290-rust-vm-superio/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-03-23 15:06:25 UTC
Doesn't build in rawhide, all (!) packages from this update was not built for rawhide, but only F38 and F37:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-909c3132b6

I've commented on the respective bugs to poke the maintainers ... I hope they'll be able to fix this.

Comment 3 fedora.dm0 2023-03-27 14:36:16 UTC
I tried another rawhide build, and it looks like all crates have been pushed, so I think all blockers are resolved now.

Comment 4 Fabio Valentini 2023-03-27 15:13:38 UTC
Looks good to me now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR BSD-3-Clause) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2023-03-27 15:36:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vm-superio

Comment 6 Fedora Update System 2023-03-27 15:52:43 UTC
FEDORA-2023-15ca34736b has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-15ca34736b

Comment 7 Fedora Update System 2023-03-27 15:54:25 UTC
FEDORA-2023-15ca34736b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-03-28 19:44:34 UTC
FEDORA-2023-02106a6c13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

Comment 9 Fedora Update System 2023-03-28 19:44:37 UTC
FEDORA-2023-a4085b6295 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

Comment 10 Fedora Update System 2023-03-29 02:02:33 UTC
FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-29 03:56:03 UTC
FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4085b6295 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-03-30 01:19:54 UTC
FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-03-31 01:34:03 UTC
FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.