Spec URL: https://qulogic.fedorapeople.org/reviews/ghc-js-chart/ghc-js-chart.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/ghc-js-chart/ghc-js-chart-2.9.4.1-1.fc37.src.rpm Description: This package bundles the minified <http://www.chartjs.org/ chart.js> code into a Haskell package, so it can be depended upon by Cabal packages. The first three components of the version number match the upstream chart.js version. The package is designed to meet the redistribution requirements of downstream users (e.g. Debian). This package is a fork of <https://hackage.haskell.org/package/js-flot js-flot> using chart.js instead of flot.
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99662711
Copr build: https://copr.fedorainfracloud.org/coprs/build/5758685 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2185353-ghc-js-chart/fedora-rawhide-x86_64/05758685-ghc-js-chart/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM - complies with Fedora Haskell Packaging Guidelines Please fix add the unlisted package datadir when importing APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 7 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/ghc-js-chart/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/js-chart-2.9.4.1 [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/ghc-9.2.6/lib, /usr/share/js-chart-2.9.4.1 I filed bug 2185357 for ghc, but please own the missing datadir. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-js- chart-data , ghc-js-chart-prof [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ghc-js-chart-2.9.4.1-1.fc39.x86_64.rpm ghc-js-chart-data-2.9.4.1-1.fc39.noarch.rpm ghc-js-chart-devel-2.9.4.1-1.fc39.x86_64.rpm ghc-js-chart-prof-2.9.4.1-1.fc39.x86_64.rpm ghc-js-chart-2.9.4.1-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjyu2npt9')] checks: 31, packages: 5 ghc-js-chart-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.2.6/lib/js-chart-2.9.4.1/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX.a ghc-js-chart-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.2.6/lib/js-chart-2.9.4.1/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX_p.a ghc-js-chart.x86_64: W: no-documentation ghc-js-chart-data.noarch: W: no-documentation ghc-js-chart-prof.x86_64: W: no-documentation ghc-js-chart-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-9.2.6/lib/js-chart-2.9.4.1/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX_p.a 5 packages and 0 specfiles checked; 2 errors, 4 warnings, 2 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 ghc-js-chart.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.2.6/lib/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX-ghc9.2.6.so /usr/lib64/ghc-9.2.6/lib/x86_64-linux-ghc-9.2.6/libHSghc-bignum-1.2-ghc9.2.6.so : ghc-js-chart-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.2.6/lib/js-chart-2.9.4.1/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX_p.a ghc-js-chart-data.noarch: W: no-documentation ghc-js-chart.x86_64: W: no-documentation ghc-js-chart-prof.x86_64: W: no-documentation ghc-js-chart-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-9.2.6/lib/js-chart-2.9.4.1/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX_p.a 4 packages and 0 specfiles checked; 390 errors, 4 warnings, 390 badness; has taken 0.3 s Unversioned so-files -------------------- ghc-js-chart: /usr/lib64/ghc-9.2.6/lib/libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX-ghc9.2.6.so Source checksums ---------------- https://hackage.haskell.org/package/js-chart-2.9.4.1/js-chart-2.9.4.1.tar.gz : CHECKSUM(SHA256) this package : 0a08efdd35bd1b8f293f9163f59305f31835304b74c3e3a1a840fc94bbc9bd0e CHECKSUM(SHA256) upstream package : 0a08efdd35bd1b8f293f9163f59305f31835304b74c3e3a1a840fc94bbc9bd0e Requires -------- ghc-js-chart (rpmlib, GLIBC filtered): ghc-js-chart-data libHSbase-4.16.4.0-ghc9.2.6.so()(64bit) libHSghc-bignum-1.2-ghc9.2.6.so()(64bit) libHSghc-prim-0.8.0-ghc9.2.6.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) ghc-js-chart-data (rpmlib, GLIBC filtered): ghc-js-chart-devel (rpmlib, GLIBC filtered): ghc-compiler ghc-devel(base-4.16.4.0) ghc-js-chart(x86-64) ghc-js-chart-prof (rpmlib, GLIBC filtered): ghc-js-chart-devel(x86-64) ghc-prof(base-4.16.4.0) Provides -------- ghc-js-chart: ghc-js-chart ghc-js-chart(x86-64) libHSjs-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX-ghc9.2.6.so()(64bit) ghc-js-chart-data: ghc-js-chart-data ghc-js-chart-devel: ghc-devel(js-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX) ghc-js-chart-devel ghc-js-chart-devel(x86-64) ghc-js-chart-static ghc-js-chart-static(x86-64) ghc-js-chart-prof: ghc-js-chart-prof ghc-js-chart-prof(x86-64) ghc-prof(js-chart-2.9.4.1-6hvGzEdkELJ3JFGr8TxcsX) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name ghc-js-chart --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic, Haskell Disabled plugins: Ocaml, Python, R, fonts, Java, Perl, PHP, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Also you need to bump the release over criterion before building. (I would suggest also converting to rpmautospec.)
Thank you for the review, Jens https://pagure.io/releng/fedora-scm-requests/issue/52634
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-js-chart
(In reply to Jens Petersen from comment #3) > Please fix add the unlisted package datadir when importing Ah, oops, I thought I had removed the glob already, but will do that. (In reply to Jens Petersen from comment #4) > Also you need to bump the release over criterion before building. > (I would suggest also converting to rpmautospec.) Yes, it's just a bit annoying when not happening with release=1.