Bug 218721 - Review Request: perl-Test-Distribution - Perform tests on all modules of a distribution
Summary: Review Request: perl-Test-Distribution - Perform tests on all modules of a di...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Test-Dist...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 218722
TreeView+ depends on / blocked
 
Reported: 2006-12-07 00:05 UTC by Chris Weyl
Modified: 2010-05-18 18:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-07 02:43:38 UTC
Type: ---
Embargoed:
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2006-12-07 00:05:52 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Test-Distribution-1.26-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Test-Distribution.spec

Description:
When using this module in a test script, it goes through all the modules in
your distribution, checks their POD, checks that they compile ok and checks
that they all define a $VERSION.

Comment 1 Jason Tibbitts 2006-12-07 02:02:08 UTC
* source files match upstream:
   64dc13f51f60f6022bb8e628f1297957  Test-Distribution-1.26.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Test::Distribution) = 1.26
   perl(Test::Distribution::base)
   perl(Test::Distribution::description)
   perl(Test::Distribution::exports)
   perl(Test::Distribution::manifest)
   perl(Test::Distribution::pod)
   perl(Test::Distribution::podcover)
   perl(Test::Distribution::prereq)
   perl(Test::Distribution::sig)
   perl(Test::Distribution::use)
   perl(Test::Distribution::versions)
   perl-Test-Distribution = 1.26-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(ExtUtils::Manifest)
   perl(File::Find::Rule) >= 0.03
   perl(Module::CoreList) >= 1.93
   perl(Module::Signature)
   perl(Pod::Coverage) >= 0.17
   perl(Test::More)
   perl(Test::Pod) >= 0.95
   perl(Test::Pod::Coverage)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful, 6 subtests skipped.
   Files=9, Tests=46,  2 wallclock secs ( 0.89 cusr +  0.24 csys =  1.13 CPU)
   The skipped checks are due to either gpg failures due to missing keys (would
probably require network access) or due to unimplemented tests.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Chris Weyl 2006-12-07 02:43:38 UTC
Imported and building for devel; branches requested for FC-[56].

Thanks for the review!

Comment 3 Patrice Dumas 2008-02-24 09:26:32 UTC
Package Change Request
======================
Package Name: perl-Test-Distribution
New Branches: EL-4 EL-5
Updated EPEL Owners: pertusus cweyl



Comment 4 Patrice Dumas 2008-02-24 09:46:17 UTC
Chris accepted my offer to be EPEL maintainer by mail, maybe he 
should confirm?

Comment 5 Kevin Fenzi 2008-02-25 21:31:21 UTC
Sure, Chris? 

Comment 6 Chris Weyl 2008-02-26 02:30:53 UTC
Sorry for the delay -- with pleasure, confirmed :)

Comment 7 Kevin Fenzi 2008-02-26 03:23:47 UTC
cvs done.

Comment 8 Paul Howarth 2010-05-13 16:07:04 UTC
Package Change Request
======================
Package Name: perl-Test-Distribution
New Branches: EL-6
Updated EPEL Owners: pghmcfc cweyl

Comment 9 Dennis Gilmore 2010-05-13 22:45:59 UTC
this was excluded from mass branching of EL-6 why is it being added now ?

Comment 10 Paul Howarth 2010-05-14 06:56:32 UTC
The EPEL-4/5 maintainer (pertusus) isn't maintaining packages in EPEL-6 (and will probably orphan EPEL-4/5 if someone else will pick it up - I will be happy to do that by the way); I didn't realise I needed this package as a dependency of one of my modules so I didn't take this package when Patrice offered his packages prior to the mass branching.

Comment 11 Dennis Gilmore 2010-05-18 18:43:53 UTC
OK

CVS Done


Note You need to log in before you can comment on or make changes to this bug.