Red Hat Bugzilla – Bug 218722
Review Request: perl-File-ExtAttr - Perl extension for accessing extended attributes of files
Last modified: 2007-11-30 17:11:51 EST
SRPM URL: http://home.comcast.net/~ckweyl/perl-File-ExtAttr-1.01-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-File-ExtAttr.spec Description: File::ExtAttr is a Perl module providing access to the extended attributes of files.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMS. + source files match upstream. 340734da69677861b80e52c41297ec8e File-ExtAttr-1.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + %check used and its failed in mock build is + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.
Imported and building for devel; branches requested for FC-[56]. Thanks for the review!