Red Hat Bugzilla – Bug 218787
Review Request: python-pycurl - A Python interface to libcurl
Last modified: 2007-12-17 11:16:11 EST
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-188.8.131.52-1.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-184.108.40.206-1.fc6.spec
PycURL is a Python interface to libcurl. PycURL can be used to fetch
objects identified by a URL from a Python program, similar to the
urllib Python module. PycURL is mature, very fast, and supports a lot
According to Packaging Naming it would be better, if a package's name were
pycurl, wouldn't it? There is no need to use 'python-' because first 'py'
letters suggest that it is a python package.
Nevertheless, there is a more serious problem namely package build fails on
x86_64. To fix it you have to change %files section to make it looks like that:
%doc COPYING ChangeLog README TODO examples doc tests
I have also removed INSTALL file as it isn't needed when package's already
* Thu Dec 7 2006 Jeffrey C. Ollie <firstname.lastname@example.org> - 220.127.116.11-2
- Remove INSTALL from the list of documentation
- Use python_sitearch for all of the files
(In reply to comment #1)
> According to Packaging Naming it would be better, if a package's name were
> pycurl, wouldn't it? There is no need to use 'python-' because first 'py'
> letters suggest that it is a python package.
The way that I read the naming guidelines pycurl would be allowed since there
was a "py" in the name, but python-pycurl was preferred. In any case, there's a
"Provide: pycurl" so that "yum install pycurl" should work.
* rpmlint is quiet
?* is the package named well?
?* is spec file name good?
* package meets Packaging Guidelines
* package is licensed with an LGPL open-source compatible license
* License field in spec file matches actual license
* license file is included in %doc
* md5sums are matching (464cfbeba150d99d92a407c7c8b751de)
* package successfully compiles on x86_64
* BuildRequires listed well
* no locales
* no need to %post and %postun sections
* not relocatable
* package owns directories well
* no duplicates in %files
* %files section includes %defattr
* proper %clean section
* macros used well
(In reply to comment #3)
> In any case, there's a
> "Provide: pycurl" so that "yum install pycurl" should work.
I can't see it anywhere so add "Provides: pycurl" into the spec file and I'll
be happy to approve this package.
(Annoyed Grunt!) I coulda swore that I had it in there... It should be there
* Thu Dec 7 2006 Jeffrey C. Ollie <email@example.com> - 18.104.22.168-3
- Don't forget to Provide: pycurl!!!
Now it looks really good :)
Thanks for the review! Imported and built for devel, branches for FC-5 and FC-6
Package Change Request
Package Name: python-pycurl
New Branches: EL-4 EL-5
Updated EPEL Owners: jcollie