Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-1.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-1.fc6.spec Description: PycURL is a Python interface to libcurl. PycURL can be used to fetch objects identified by a URL from a Python program, similar to the urllib Python module. PycURL is mature, very fast, and supports a lot of features.
According to Packaging Naming it would be better, if a package's name were pycurl, wouldn't it? There is no need to use 'python-' because first 'py' letters suggest that it is a python package. Nevertheless, there is a more serious problem namely package build fails on x86_64. To fix it you have to change %files section to make it looks like that: %files %defattr(-,root,root,-) %doc COPYING ChangeLog README TODO examples doc tests %{python_sitearch}/curl %{python_sitearch}/pycurl.so I have also removed INSTALL file as it isn't needed when package's already installed.
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-2.fc6.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-2.fc6.spec %changelog * Thu Dec 7 2006 Jeffrey C. Ollie <jeff> - 7.15.5.1-2 - Remove INSTALL from the list of documentation - Use python_sitearch for all of the files
(In reply to comment #1) > According to Packaging Naming it would be better, if a package's name were > pycurl, wouldn't it? There is no need to use 'python-' because first 'py' > letters suggest that it is a python package. The way that I read the naming guidelines pycurl would be allowed since there was a "py" in the name, but python-pycurl was preferred. In any case, there's a "Provide: pycurl" so that "yum install pycurl" should work.
MUST items: * rpmlint is quiet ?* is the package named well? ?* is spec file name good? * package meets Packaging Guidelines * package is licensed with an LGPL open-source compatible license * License field in spec file matches actual license * license file is included in %doc * md5sums are matching (464cfbeba150d99d92a407c7c8b751de) * package successfully compiles on x86_64 * BuildRequires listed well * no locales * no need to %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * %files section includes %defattr * proper %clean section * macros used well (In reply to comment #3) > In any case, there's a > "Provide: pycurl" so that "yum install pycurl" should work. I can't see it anywhere so add "Provides: pycurl" into the spec file and I'll be happy to approve this package.
(Annoyed Grunt!) I coulda swore that I had it in there... It should be there now though: Spec: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-3.fc6.spec SRPM: http://repo.ocjtech.us/misc/fedora/6/SRPMS/python-pycurl-7.15.5.1-3.fc6.src.rpm %changelog * Thu Dec 7 2006 Jeffrey C. Ollie <jeff> - 7.15.5.1-3 - Don't forget to Provide: pycurl!!!
Now it looks really good :) Approved!
Thanks for the review! Imported and built for devel, branches for FC-5 and FC-6 requested.
Package Change Request ====================== Package Name: python-pycurl New Branches: EL-4 EL-5 Updated EPEL Owners: jcollie
cvs done.