Bug 2193069 - python-vcstools fails to build with Python 3.12: AttributeError: 'GitClientAffectedFiles' object has no attribute 'assertEquals'.
Summary: python-vcstools fails to build with Python 3.12: AttributeError: 'GitClientAf...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: python-vcstools
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.12
TreeView+ depends on / blocked
 
Reported: 2023-05-04 08:20 UTC by Tomáš Hrnčiar
Modified: 2023-08-16 07:13 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2023-05-04 08:20:08 UTC
python-vcstools fails to build with Python 3.12.0a7.

======================================================================
ERROR: test_get_affected_files (test.test_git.GitClientAffectedFiles.test_get_affected_files)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 622, in test_get_affected_files
    self.assertEquals(['local_file'], affected)
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientAffectedFiles' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_defaults (test.test_git.GitClientLogTest.test_get_log_defaults)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 585, in test_get_log_defaults
    self.assertEquals(self.n_commits + 1, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_limit (test.test_git.GitClientLogTest.test_get_log_limit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 593, in test_get_log_limit
    self.assertEquals(1, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_path (test.test_git.GitClientLogTest.test_get_log_path)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 600, in test_get_log_path
    self.assertEquals(1, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testDiffClean (test.test_git.GitClientTest.testDiffClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 485, in testDiffClean
    self.assertEquals('', client.get_diff())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusClean (test.test_git.GitClientTest.testStatusClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 489, in testStatusClean
    self.assertEquals('', client.get_status(porcelain=True))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testDiff (test.test_git.GitDiffStatClientTest.testDiff)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 867, in testDiff
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testDiffRelpath (test.test_git.GitDiffStatClientTest.testDiffRelpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 903, in testDiffRelpath
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatus (test.test_git.GitDiffStatClientTest.testStatus)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 939, in testStatus
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusRelPath (test.test_git.GitDiffStatClientTest.testStatusRelPath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 953, in testStatusRelPath
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusUntracked (test.test_git.GitDiffStatClientTest.testStatusUntracked)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_git.py", line 967, in testStatusUntracked
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'GitDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_defaults (test.test_hg.HGClientLogTest.test_get_log_defaults)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 263, in test_get_log_defaults
    self.assertEquals(4, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_limit (test.test_hg.HGClientLogTest.test_get_log_limit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 272, in test_get_log_limit
    self.assertEquals(1, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_path (test.test_hg.HGClientLogTest.test_get_log_path)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 279, in test_get_log_path
    self.assertEquals('initial', log[0]['message'])
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testDiffClean (test.test_hg.HGClientTest.testDiffClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 236, in testDiffClean
    self.assertEquals('', client.get_diff())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusClean (test.test_hg.HGClientTest.testStatusClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 240, in testStatusClean
    self.assertEquals('', client.get_status())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusUntracked (test.test_hg.HGDiffStatClientTest.testStatusUntracked)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 364, in testStatusUntracked
    self.assertEquals('M modified-fs.txt\nM modified.txt\nA added.txt\nR deleted.txt\n! deleted-fs.txt\n? added-fs.txt\n', client.get_status(untracked=True))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_diff (test.test_hg.HGDiffStatClientTest.test_diff)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 334, in test_diff
    self.assertEquals('diff --git ./added.txt ./added.txt\nnew file mode 100644\n--- /dev/null\n+++ ./added.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file\ndiff --git ./deleted.txt ./deleted.txt\ndeleted file mode 100644\ndiff --git ./modified-fs.txt ./modified-fs.txt\n--- ./modified-fs.txt\n+++ ./modified-fs.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file\ndiff --git ./modified.txt ./modified.txt\n--- ./modified.txt\n+++ ./modified.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file', client.get_diff())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_diff_relpath (test.test_hg.HGDiffStatClientTest.test_diff_relpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 342, in test_diff_relpath
    self.assertEquals('diff --git local/added.txt local/added.txt\nnew file mode 100644\n--- /dev/null\n+++ local/added.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file\ndiff --git local/deleted.txt local/deleted.txt\ndeleted file mode 100644\ndiff --git local/modified-fs.txt local/modified-fs.txt\n--- local/modified-fs.txt\n+++ local/modified-fs.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file\ndiff --git local/modified.txt local/modified.txt\n--- local/modified.txt\n+++ local/modified.txt\n@@ -0,0 +1,1 @@\n+0123456789abcdef\n\\ No newline at end of file', client.get_diff(basepath=os.path.dirname(self.local_path)))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_status (test.test_hg.HGDiffStatClientTest.test_status)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 352, in test_status
    self.assertEquals('M modified-fs.txt\nM modified.txt\nA added.txt\nR deleted.txt\n! deleted-fs.txt\n', client.get_status())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_status_relpath (test.test_hg.HGDiffStatClientTest.test_status_relpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_hg.py", line 358, in test_status_relpath
    self.assertEquals('M local/modified-fs.txt\nM local/modified.txt\nA local/added.txt\nR local/deleted.txt\n! local/deleted-fs.txt\n', client.get_status(basepath=os.path.dirname(self.local_path)))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'HGDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_defaults (test.test_svn.SvnClientLogTest.test_get_log_defaults)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 304, in test_get_log_defaults
    self.assertEquals(3, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnClientLogTest' object has no attribute 'assertEquals'
-------------------- >> begin captured logging << --------------------
vcstools: ERROR: Can't remove /tmp/tmpawbf6tsa/local
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: test_get_log_limit (test.test_svn.SvnClientLogTest.test_get_log_limit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 315, in test_get_log_limit
    self.assertEquals(1, len(log))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_get_log_path (test.test_svn.SvnClientLogTest.test_get_log_path)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 322, in test_get_log_path
    self.assertEquals('initial', log[0]['message'])
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnClientLogTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testDiffClean (test.test_svn.SvnClientTest.testDiffClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 277, in testDiffClean
    self.assertEquals('', client.get_diff())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: testStatusClean (test.test_svn.SvnClientTest.testStatusClean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 281, in testStatusClean
    self.assertEquals('', client.get_status())
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_diff (test.test_svn.SvnDiffStatClientTest.test_diff)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 419, in test_diff
    self.assertEqualDiffs('Index: added.txt\n===================================================================\n--- added.txt\t(revision 0)\n+++ added.txt\t(revision 0)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file\nIndex: modified-fs.txt\n===================================================================\n--- modified-fs.txt\t(revision 3)\n+++ modified-fs.txt\t(working copy)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file\nIndex: modified.txt\n===================================================================\n--- modified.txt\t(revision 3)\n+++ modified.txt\t(working copy)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file',
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 412, in assertEqualDiffs
    self.assertEquals(set(expected_blocks), set(filtered_actual_blocks))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

======================================================================
ERROR: test_diff_relpath (test.test_svn.SvnDiffStatClientTest.test_diff_relpath)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 427, in test_diff_relpath
    self.assertEqualDiffs('Index: local/added.txt\n===================================================================\n--- local/added.txt\t(revision 0)\n+++ local/added.txt\t(revision 0)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file\nIndex: local/modified-fs.txt\n===================================================================\n--- local/modified-fs.txt\t(revision 3)\n+++ local/modified-fs.txt\t(working copy)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file\nIndex: local/modified.txt\n===================================================================\n--- local/modified.txt\t(revision 3)\n+++ local/modified.txt\t(working copy)\n@@ -0,0 +1 @@\n+0123456789abcdef\n\\ No newline at end of file', client.get_diff(basepath=os.path.dirname(self.local_path)).rstrip())
  File "/builddir/build/BUILD/vcstools-0.1.42/test/test_svn.py", line 412, in assertEqualDiffs
    self.assertEquals(set(expected_blocks), set(filtered_actual_blocks))
    ^^^^^^^^^^^^^^^^^
AttributeError: 'SvnDiffStatClientTest' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

Removed many old deprecated unittest features:

    - A number of TestCase method aliases:

    | Deprecated alias      |  Method Name           | Deprecated in |
    +-----------------------|------------------------|---------------+
    | failUnless            | assertTrue()           |      3.1      |
    | failIf                | assertFalse()          |      3.1      |
    | failUnlessEqual       | assertEqual()          |      3.1      |
    | failIfEqual           | assertNotEqual()       |      3.1      |
    | failUnlessAlmostEqual | assertAlmostEqual()    |      3.1      |
    | failIfAlmostEqual     | assertNotAlmostEqual() |      3.1      |
    | failUnlessRaises      | assertRaises()         |      3.1      |
    | assert_               | assertTrue()           |      3.2      |
    | assertEquals          | assertEqual()          |      3.2      |
    | assertNotEquals       | assertNotEqual()       |      3.2      |
    | assertAlmostEquals    | assertAlmostEqual()    |      3.2      |
    | assertNotAlmostEquals | assertNotAlmostEqual() |      3.2      |
    | assertRegexpMatches   | assertRegex()          |      3.2      |
    | assertRaisesRegexp    | assertRaisesRegex()    |      3.2      |
    | assertNotRegexpMatches| assertNotRegex()       |      3.5      |
    +-----------------------|------------------------|---------------+

    You can use https://github.com/isidentical/teyit to automatically modernise your unit tests.

    - Undocumented and broken TestCase method assertDictContainsSubset (deprecated in Python 3.2).

    - Undocumented TestLoader.loadTestsFromModule parameter use_load_tests (deprecated and ignored since Python 3.2).

    - An alias of the TextTestResult class: _TextTestResult (deprecated in Python
3.2).


https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05841176-python-vcstools/

For all our attempts to build python-vcstools with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-vcstools/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Fedora Admin user for bugzilla script actions 2023-07-14 12:46:03 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 2 Fedora Release Engineering 2023-08-16 07:13:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.


Note You need to log in before you can comment on or make changes to this bug.