Bug 219758 - init.d/halt script unmount takes too long due to sleeps
init.d/halt script unmount takes too long due to sleeps
Status: CLOSED WONTFIX
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: initscripts (Show other bugs)
4.4
All Linux
medium Severity medium
: ---
: ---
Assigned To: Bill Nottingham
Brock Organ
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-15 02:11 EST by Tamas Kerecsen
Modified: 2014-03-16 23:04 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-12-15 11:32:04 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
A patch illustrating one way to make the halt sctipt run faster without compromising functionality (1.95 KB, patch)
2006-12-15 02:11 EST, Tamas Kerecsen
no flags Details | Diff

  None (edit)
Description Tamas Kerecsen 2006-12-15 02:11:56 EST
Description of problem:
At two places, the init.d halt script has a 2 second sleep after unmounting
certain paths and before checking whether the action was successful. Under
typical conditions, the 2 second sleep is completely unnecessary. Collectively
these two sleeps slow down the shutdown process by almost 4 seconds.

Version-Release number of selected component (if applicable):
N/A

How reproducible:

Steps to Reproduce:
1. Execute /sbin/halt and measure time. 
2. Apply attached patch, run /sbin/halt again and measure time. 
3. Shutdown will be 3-4 seconds faster with patch.
  
Actual results:
See above

Expected results:
See above

Additional info:
On most systems even the 0.1 sec sleep I included is unnecessary, so feel free
to remove it.

The patch also comments out the "devremaining" variable assignments that look
like they have been left behind accidentally.
Comment 1 Tamas Kerecsen 2006-12-15 02:11:57 EST
Created attachment 143738 [details]
A patch illustrating one way to make the halt sctipt run faster without compromising functionality
Comment 2 Bill Nottingham 2006-12-15 11:32:04 EST
I've cloned this issue for the Fedora Core development tree; it can be tracked
there as bug 219816, as that's where we'll tackle it for future releases.

Given that this does not affect the actual functionality of the script, this is
something we're unlikely to tackle in a update for Red Hat Enterprise Linux 4 in
the future - we're concentrating more on bug fixes and regressions. We'll try
and get this fixed for future releases of Red Hat Enterprise Linux. Closing as
WONTFIX for RHEL4.

Note You need to log in before you can comment on or make changes to this bug.