Bug 219816 - init.d/halt script unmount takes too long due to sleeps
Summary: init.d/halt script unmount takes too long due to sleeps
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: initscripts
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Brock Organ
URL:
Whiteboard:
Depends On:
Blocks: F8Target
TreeView+ depends on / blocked
 
Reported: 2006-12-15 16:28 UTC by Bill Nottingham
Modified: 2014-03-17 03:04 UTC (History)
1 user (show)

Fixed In Version: 8.58-1
Clone Of:
Environment:
Last Closed: 2007-10-08 19:31:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Bill Nottingham 2006-12-15 16:28:55 UTC
+++ This bug was initially created as a clone of Bug #219758 +++

Description of problem:
At two places, the init.d halt script has a 2 second sleep after unmounting
certain paths and before checking whether the action was successful. Under
typical conditions, the 2 second sleep is completely unnecessary. Collectively
these two sleeps slow down the shutdown process by almost 4 seconds.

Version-Release number of selected component (if applicable):
N/A

How reproducible:

Steps to Reproduce:
1. Execute /sbin/halt and measure time. 
2. Apply attached patch, run /sbin/halt again and measure time. 
3. Shutdown will be 3-4 seconds faster with patch.
  
Actual results:
See above

Expected results:
See above

Additional info:
On most systems even the 0.1 sec sleep I included is unnecessary, so feel free
to remove it.

The patch also comments out the "devremaining" variable assignments that look
like they have been left behind accidentally.

-- Additional comment from kerecsen on 2006-12-15 02:11 EST --
Created an attachment (id=143738)
A patch illustrating one way to make the halt sctipt run faster without
compromising functionality

Comment 1 Bill Nottingham 2007-10-08 19:31:52 UTC
Fixed in CVS, will be in 8.58-1.


Note You need to log in before you can comment on or make changes to this bug.