Red Hat Bugzilla – Bug 219915
Review Request: kio_resources - Kio_resources provides the "resources" protocol for KDE
Last modified: 2007-11-30 17:11:51 EST
Spec URL: http://tux.u-strasbg.fr/~chit/kio_resources/kio_resources.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/kio_resources/kio_resources-0.2-1.src.rpm
kio_resources provides the "resources" protocol for KDE.
It allows you to browse all installed files in the standard
search paths (generally .kde and /usr). The general format
of a resources URL is resources:/resource-type[/relative-path].
Thus, to view all wallpapers installed on your system, both in
your home directory and in the KDE installation path, you type
resources:/wallpaper. If you simply want to look through all
the available resource types, use resources:/.
== Not an official review as I'm not yet sponsored ==
The spec file seems to be ok.
rpmlint's out is clean, packages build correctly with mock.
It is prereview, I am not sponsored.
Rpmlint return NULL, so OK. I didn't check build with mock, but under normal
user it built correct.
I think You should use macros in source-url.
change for example:
And the last: Is kdebase realy needed by this package?
(In reply to comment #2)
> I think You should use macros in source-url.
> change for example:
to please you, I'll modify it for the next release since it is not really a blocker
> And the last: Is kdebase realy needed by this package?
This package is useless without konqueror
chitlesh(~)$rpm -qf /usr/bin/konqueror
I'll review this.
Pretty simple and straight-forward.
* builds in mock environment.
* MUST: SOURCE matches upstream
I'll leave these up to you to consider:
* SHOULD: Summary shouldn't include pkg name (ie, don't include Kio_resources)
* SHOULD: Description is too long, imo. Could probably omit 2nd paragraph.
Thanks Rex :)
* Mon Jan 01 2007 Chitlesh Goorah <chitlesh [AT] fedoraproject DOT org> - 0.2-2
- Removed package name from summary
- Fixed description, since it was too long