Spec URL: https://yselkowitz.fedorapeople.org/gmult.spec SRPM URL: https://yselkowitz.fedorapeople.org/gmult-12.0-1.fc39.src.rpm Description: Multiplication Puzzle is a simple game inspired by the multiplication game inside the popular editor emacs. You are presented with a long multiplication problem where a 3-digit number is multiplied by a 2-digit number, yielding two intermediate 4-digit number and a final 5-digit answer. However, all the digits are replaced by letters. Your job is to discover which letters are which digits. Fedora Account System Username: yselkowitz
Taking for review. Looks like nice and clean packaging, but it doesn't seem to build: $ mock -r fedora-rawhide-x86_64 ./gmult-12.0-1.fc39.src.rpm [snip] ../gmult/DigitBox.vala:72.5-72.32: warning: `Gtk.Widget.translate_coordinates' has been deprecated since 4.12 72 | window.translate_coordinates(this, 0, 0, out x_offset, out y_offset); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../gmult/main.vala:112.5-112.27: warning: `Gtk.CssProvider.load_from_data' has been deprecated since 4.12 112 | provider.load_from_data(css.data); | ^~~~~~~~~~~~~~~~~~~~~~~ ../gmult/main.vala:112.29-112.36: error: Argument 1: Cannot convert from `unowned uint8[]' to `unowned string' 112 | provider.load_from_data(css.data); | ^~~~~~~~ ../gmult/main.vala:112.5-112.37: error: 1 missing arguments for `void Gtk.CssProvider.load_from_data (string, ssize_t)' 112 | provider.load_from_data(css.data); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Compilation failed: 2 error(s), 2 warning(s) Any ideas? Looks like something changed in vala?
Fedora review gmult-12.0-1.fc39.src.rpm 2023-08-18 $ rpmlint /var/lib/mock/fedora-38-x86_64/result/gmult-* =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 gmult.src: W: strange-permission gmult.spec 600 gmult.x86_64: W: no-manual-page-for-binary gmult gmult.src: E: description-line-too-long Multiplication Puzzle is a simple game inspired by the multiplication game inside gmult.src: E: description-line-too-long where a 3-digit number is multiplied by a 2-digit number, yielding two intermediate gmult.x86_64: E: description-line-too-long Multiplication Puzzle is a simple game inspired by the multiplication game inside gmult.x86_64: E: description-line-too-long where a 3-digit number is multiplied by a 2-digit number, yielding two intermediate ==================================================== 4 packages and 0 specfiles checked; 4 errors, 2 warnings, 4 badness; has taken 0.3 s ==================================================== + OK ! needs attention ! rpmlint output Can you fix the line wrapping so that rpmlint is happy? + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. ! The license field in the spec file matches the actual license In addition to GPL licensed source code, a few files appear to be under different licenses: The .ui files in data/ui/ under CC-BY-SA-4.0, and /po/LINGUAS and po/POTFILES.in under CC0-1.0. Can you include those two licenses in the license field as well, please? ! The license text (LICENSE.md) is included in %license There is also LICENSES/ directory that has the other two missing license texts and these should be included in %license as well. + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm SHA512 (gmult-12.0.tar.bz2) = 617b51defaf61c7967c9ccd6898209330733709df4290717e6c158719d04c61a38fa6832197c937f8aef1da23dc2f820c707291761ef8437ab0e78850253768c SHA512 (Download/gmult-12.0.tar.bz2) = 617b51defaf61c7967c9ccd6898209330733709df4290717e6c158719d04c61a38fa6832197c937f8aef1da23dc2f820c707291761ef8437ab0e78850253768c ! Package builds in mock It builds for f38, but fails for rawhide. n/a ExcludeArch bugs filed + BuildRequires look sane + locale handling looks good + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base + Packages should not contain libtool .la files + Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 + Package does not depend on deprecated packages
Spec URL: https://yselkowitz.fedorapeople.org/gmult.spec SRPM URL: https://yselkowitz.fedorapeople.org/gmult-12.0-1.fc40.src.rpm Description: Multiplication Puzzle is a simple game inspired by the multiplication game inside the popular editor emacs. You are presented with a long multiplication problem where a 3-digit number is multiplied by a 2-digit number, yielding two intermediate 4-digit number and a final 5-digit answer. However, all the digits are replaced by letters. Your job is to discover which letters are which digits. Fedora Account System Username: yselkowitz
(In reply to Kalev Lember from comment #2) > Can you fix the line wrapping so that rpmlint is happy? Done. > In addition to GPL licensed source code, a few files appear to be under > different licenses: > The .ui files in data/ui/ under CC-BY-SA-4.0, and /po/LINGUAS and > po/POTFILES.in under CC0-1.0. > Can you include those two licenses in the license field as well, please? Added CC-BY-SA-4.0. But LINGUAS and POTFILES.in are build system files, and License is supposed to reflect the *binary* package(s). > There is also LICENSES/ directory that has the other two missing license > texts and these should be included in %license as well. Done wrt CC-BY-SA-4.0. > It builds for f38, but fails for rawhide. This was filed three months ago, before the new gtk4 version landed. I have incorporated a fix for the apparent API change in 4.12, but it needs to be applied conditionally so that this can still be built with 4.10 (F38).
Copr build: https://copr.fedorainfracloud.org/coprs/build/6314948 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2203715-gmult/fedora-rawhide-x86_64/06314948-gmult/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks! Looks good to me now. APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/gmult
FEDORA-2023-fbfd5e8fd4 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fbfd5e8fd4
FEDORA-2023-fbfd5e8fd4 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fbfd5e8fd4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fbfd5e8fd4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-FLATPAK-2023-d44031a0e0 has been submitted as an update to Fedora 38 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-d44031a0e0
FEDORA-FLATPAK-2023-d44031a0e0 has been pushed to the Fedora 38 Flatpaks testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2023-d44031a0e0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-fbfd5e8fd4 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-FLATPAK-2023-d44031a0e0 has been pushed to the Fedora 38 Flatpaks stable repository. If problem still persists, please make note of it in this bug report.