Spec URL: http://freeshell.in/~kushal/librfid.spec SRPM URL: http://freeshell.in/~kushal/librfid-0.1.0-1.src.rpm Description: librfid is a Free Software RFID library. It implements the PCD (reader) side protocol stack of ISO 14443 A, ISO 14443 B, ISO 15693, Mifare Ultralight and Mifare Classic. Support for iCODE and other 13.56MHz based transponders is planned.
MD5Sum: 695e7f30f570a08407e42ed278ca2fe3 librfid-0.1.0.tar.bz2 Good: * Source URL is canonical. * License field in spec, match tarball license. * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros. * All necessary BuildRequires listed. * Files have appropriate permissions and owners. * Package name conforms to the Fedora Naming Guidelines. * rpmlint produces no errors. * Package builds in Mock fine. * Package install and uninstalls cleanly on FC6. Minor: * I really don't think you need to add the same docs that are in the main package to the devel package. This isn't a blocker, but I would drop them. +1 APPROVED
One thing to consider: The %{_bindir}/send_script in the main package has a very generic file name and bears the risk of creating a conflict with other packages. The upstream authors are advised to choose a more unique file name.
(In reply to comment #1) > Minor: > * I really don't think you need to add the same docs that are in the main > package to the devel package. This isn't a blocker, but I would drop them. > > +1 APPROVED Done :)
(In reply to comment #2) > One thing to consider: > > The %{_bindir}/send_script in the main package has a very generic > file name and bears the risk of creating a conflict with other > packages. The upstream authors are advised to choose a more unique > file name. > Will inform the upstream authors.
(I'm the upstream author): The send_script program has been renamed into librfid_send_script in our SVN tree. The next release of the library will reflact that change. Thanks for letting us know.