Bug 2211432 (review-rust-ureq) - Review Request: rust-ureq - Simple, safe HTTP client
Summary: Review Request: rust-ureq - Simple, safe HTTP client
Keywords:
Status: CLOSED DUPLICATE of bug 2256434
Alias: review-rust-ureq
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2254823 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-05-31 15:38 UTC by Michel Lind
Modified: 2024-01-07 22:55 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-02 13:40:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Michel Lind 2023-05-31 15:38:30 UTC
Spec URL: https://salimma.fedorapeople.org/rust-ureq.spec
SRPM URL: https://salimma.fedorapeople.org/rust-ureq-2.6.2-1.fc39.src.rpm

Description:
Simple, safe HTTP client.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-05-31 18:10:53 UTC
Please disable all rustls related functionality and make native-tls the default tls backend.
Otherwise this package will be unusable on half our supported architectures.

Comment 2 Michel Lind 2023-06-08 18:26:55 UTC
Ah, thanks! I'll look into this

Comment 3 Fabio Valentini 2023-07-29 14:15:16 UTC
Note that rustls dependencies + features can now theoretically remain in the package, they just can't be part of the default feature set. I still recommend that you remove the rustls related features (because you won't be able to use them on all architectures), but it's no longer a hard requirement.

The rustls packages are now available on all architectures, they just don't work on some of them (this should make packaging things that depend on them easier).

Comment 4 Fabio Valentini 2023-07-30 17:31:50 UTC
BTW, version 2.7.1 has been released in the meantime, it would be great if this could be updated to a newer version.
Note that the cookie_store crate in Fedora is currently too old for ureq (at v0.16, ureq needs v0.19).

If you need cookie related functionality, I can work on updating the cookie_store crate, otherwise I'd recommend just disabling features that depend on cookie_store v0.19 for now.

Comment 5 Fabio Valentini 2023-12-16 16:42:42 UTC
*** Bug 2254823 has been marked as a duplicate of this bug. ***

Comment 6 Onuralp Sezer 2024-01-02 13:40:03 UTC
Since this review stay inactive too long, I made a new review with updated version. 

URL: https://bugzilla.redhat.com/show_bug.cgi?id=2256434

Thank you

*** This bug has been marked as a duplicate of bug 2256434 ***


Note You need to log in before you can comment on or make changes to this bug.