Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/hebcal/fedora-rawhide-x86_64/06018685-hebcal/hebcal.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/hebcal/fedora-rawhide-x86_64/06018685-hebcal/hebcal-5.8.0-1.fc39.src.rpm Description: CLI perpetual Jewish Calendar Fedora Account System Username: fuller
> BuildRequires: golang-github-hebcal-devel Does this not get included automatically when using the %go_generate_buildrequires macro?
Since this is a binary-only package, you should probably remove the %gopkgfiles line. That line creates an additional golang-github-hebcal-devel package that will overwrite the other golang-github-hebcal-devel package. There is no point to shipping the source code to hebcal (the binary) in a Fedora-style gocode package. The SRPM covers the requirement to ship source code.
(In reply to Link Dupont from comment #1) > > BuildRequires: golang-github-hebcal-devel > > Does this not get included automatically when using the > %go_generate_buildrequires macro? It is not automatically included - see https://download.copr.fedorainfracloud.org/results/fuller/hebcal/fedora-rawhide-x86_64/06172977-hebcal/builder-live.log.gz where the "BuildRequires" is commented out
It looks like the fact that github.com/hebcal/hebcal-go and github.com/hebcal/hebcal are separate Go packages is confusing golist. When I run golist without --skip-self, it includes the github.com/hebcal/hebcal-go package requirements: link@thelio:~/.../hebcal/hebcal$ golist --imported --package-path $goipath github.com/hebcal/greg github.com/hebcal/hdate github.com/hebcal/hebcal-go/event github.com/hebcal/hebcal-go/hebcal github.com/hebcal/hebcal-go/locales github.com/hebcal/hebcal-go/yerushalmi github.com/hebcal/hebcal-go/zmanim github.com/pborman/getopt/v2 However, when run with --skip-self (as golist is run by the %go_generate_buildrequires macro), it incorrectly assumes those packages are local: link@thelio:~/.../hebcal/hebcal$ golist --imported --package-path $goipath --skip-self github.com/hebcal/greg github.com/hebcal/hdate github.com/pborman/getopt/v2 Ideally, the right solution here is for upstream to move github.com/hebcal/hebcal into a package within github.com/hebcal/hebcal-go (using the cmd/hebcal convention). Then one RPM would provide both the github.com/hebcal/hebcal-go source files, and then resulting github.com/hebcal/hebcal-go/cmd/hebcal binary. Maybe make a note by the manual BuildRequires: line that notes why that requirement is present. Alternatively, you could forgo using %go_generate_buildrequires and use a manual list. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_automatic_dependency_generation for an example of using golist manually.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.