RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2219388 - [RHEL8] pcs: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation)
Summary: [RHEL8] pcs: Python tarfile extraction needs change to avoid a warning (CVE-2...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: pcs
Version: 8.9
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: rc
: 8.9
Assignee: Tomas Jelinek
QA Contact: cluster-qe
URL:
Whiteboard:
Depends On:
Blocks: CVE-2007-4559 2219407
TreeView+ depends on / blocked
 
Reported: 2023-07-03 12:29 UTC by Petr Viktorin (pviktori)
Modified: 2023-11-14 15:56 UTC (History)
9 users (show)

Fixed In Version: pcs-0.10.17-2.el8
Doc Type: Bug Fix
Doc Text:
I suppose this is going to be documented together with bz263261
Clone Of:
: 2219407 (view as bug list)
Environment:
Last Closed: 2023-11-14 15:22:35 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker CLUSTERQE-6801 0 None None None 2023-07-07 11:10:57 UTC
Red Hat Issue Tracker RHELPLAN-161442 0 None None None 2023-07-03 12:29:53 UTC
Red Hat Product Errata RHBA-2023:6903 0 None None None 2023-11-14 15:23:15 UTC

Description Petr Viktorin (pviktori) 2023-07-03 12:29:05 UTC 
Hello,
In RHEL 9.3 and 8.9, we're planning to fix the long-standing CVE-2007-4559: Python's `tarfile` module makes it too easy to extract tarballs in an unsafe way.
Unfortunately, for the CVE to be considered fixed, this needs a behavior change. (If you don't think this is the case, let's bring it up with the security team.)
Upstream, Python will emit deprecation warnings for 2 releases, but in RHEL we change the behavior now, emit warnings, and provide ways for customers to restore earlier behavior.
To avoid the warning, software shipped by Red Hat will need a change.

For more details see upstream PEP 706: https://peps.python.org/pep-0706
and the Red Hat knowledge base draft: https://access.redhat.com/articles/7004769

---

As reported on rhel devel (thanks!), pcs uses extractall in:

https://github.com/ClusterLabs/pcs/blob/main/pcs/config.py#L491
https://github.com/ClusterLabs/pcs/blob/main/pcs/config.py#L498


The call will emit a warning by default. To prevent that, add something like this before the call:

tarball.extraction_filter = getattr(tarfile, 'data_filter',
                                    (lambda member, path: member))

This is compatible with unpatched versions of Python. If you only build for RHEL8.9+, instead add an argument to the call:
`tarball.extractall(..., filter='data')`.

I don't know about the tarball you're extracting here.
If it's pure data (configuration files), use 'data_filter' (or filter='data') as above.
If it's a trusted system archive, use 'fully_trusted_filter' (or filter='fully_trusted').
There's also 'tar_filter', somewhere in between.

See the docs for details: https://docs.python.org/3/library/tarfile.html?default-named-filters

---

Let me know if you have any questions!
Comment 2 Tomas Jelinek 2023-07-12 14:16:24 UTC 
Upstream patch: https://github.com/ClusterLabs/pcs/commit/44301c7ba83c5efa9db1113bd9491de796ebded4

Test:

Make sure to install patched python packages - they make unpatched pcs print a warning.

[root@rh88-node1:~]# rpm -q platform-python
platform-python-3.6.8-52.el8.x86_64

Before fix:
[root@rh88-node1:~]# pcs config restore /root/backup.tar.bz2 --local
/usr/lib64/python3.6/tarfile.py:2214: RuntimeWarning: The default behavior of tarfile extraction has been changed to disallow common exploits (including CVE-2007-4559). By default, absolute/parent paths are disallowed and some mode bits are cleared. See https://access.redhat.com/articles/7004769 for more details.
  RuntimeWarning)
[root@rh88-node1:~]# echo $?
0

After fix:
[root@rh88-node1:~]# pcs/pcs config restore /root/backup.tar.bz2 --local
[root@rh88-node1:~]# echo $?
0

Verify, that 'pcs config restore' and 'pcs config restore --local' works - if in doubt, see bz1024492 for original tests.
Comment 3 Michal Pospisil 2023-07-14 08:41:28 UTC 
DevTestResults:

[root@r08-09-a ~]# pcs config backup /root/backup.tar.bz2

[root@r08-09-a ~]# pcs cluster destroy
Shutting down pacemaker/corosync services...
Killing any remaining services...
Removing all cluster configuration files...

[root@r08-09-a ~]# pcs config restore /root/backup.tar.bz2 --local

[root@r08-09-a ~]# echo $?
0
Comment 8 Michal Mazourek 2023-08-21 15:26:04 UTC 
The same test as in bz2219407 comment 8 was conducted to verify this bz.

Marking as VERIFIED for pcs-0.10.17-2.el8.
Comment 10 errata-xmlrpc 2023-11-14 15:22:35 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6903
Note You need to log in before you can comment on or make changes to this bug.