Bug 2221224 - Review Request: rust-regex-test - Infrastructure for testing regexes
Summary: Review Request: rust-regex-test - Infrastructure for testing regexes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/regex-test
Whiteboard:
Depends On:
Blocks: 2219813 2221221
TreeView+ depends on / blocked
 
Reported: 2023-07-07 15:01 UTC by Fabio Valentini
Modified: 2023-07-11 19:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-11 19:07:47 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-07-07 15:01:18 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-regex-test.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-regex-test-0.1.0-1.fc38.src.rpm

Description:
Infrastructure for testing regexes. You probably don't want to use this
crate unless you're working on a regex implementation.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-07-07 15:01:21 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103047693

Comment 2 Fedora Review Service 2023-07-07 15:07:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6149948
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2221224-rust-regex-test/fedora-rawhide-x86_64/06149948-rust-regex-test/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2023-07-11 17:44:35 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fabio Valentini 2023-07-11 18:44:38 UTC
Thanks a lot for the review! If you could take a look at regex-lite (#2221221) as well, that would unblock a couple updates for me.

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-11 18:45:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-regex-test

Comment 6 Fabio Valentini 2023-07-11 19:07:47 UTC
Imported and built:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2230457


Note You need to log in before you can comment on or make changes to this bug.