Bug 2233188 - Review Request: golang-modernc-ccgo-4 - C compiler targeting Go
Summary: Review Request: golang-modernc-ccgo-4 - C compiler targeting Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2231451
Blocks: 2231928
TreeView+ depends on / blocked
 
Reported: 2023-08-21 16:25 UTC by W. Michael Petullo
Modified: 2023-10-03 21:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-26 01:58:18 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-21 16:25:31 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-4.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-4-3.16.15-1.fc38.src.rpm
Description: C compiler targeting Go
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-26 14:16:01 UTC
On dependency is broken:

DEBUG util.py:442:  Error: 
DEBUG util.py:442:   Problem: conflicting requests
DEBUG util.py:442:    - nothing provides golang(modernc.org/cc/v3) needed by golang-modernc-ccgo-3-devel-3.16.14-1.fc40.noarch from copr:copr.fedorainfracloud.org:mikep:golang
DEBUG util.py:444:  (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
DEBUG util.py:595:  Child return code was: 1

Comment 2 Robert-André Mauchin 🐧 2023-08-26 15:04:33 UTC
 - error: File not found: /builddir/build/BUILDROOT/golang-modernc-ccgo-4-3.16.15-1.fc40.x86_64/usr/share/doc/golang-modernc-ccgo-4/README.md

->

find . ! \( -name v4 -o -name _build  -o -name LICENSE -o -name AUTHORS -o -name CONTRIBUTORS -o -name README.md \) -maxdepth 1 -exec rm -rvf {} \;



 -> Don't add %global debug_package %{nil} if you build the binary. In general just build the binary for one of the version of ccgo, ideally the latest, but here since there is no official v4, i'd stick with the v3. So drop the binary in this package.

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Please take my comments into account.

Comment 3 W. Michael Petullo 2023-08-27 14:44:24 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-4.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-4-3.16.15-1.fc38.src.rpm

- Fix README.md
- Do not remove non-existing checks
- Do not package v4 binary

Comment 4 W. Michael Petullo 2023-08-27 15:04:53 UTC
I resolved the dependency problem by building golang-modernc-cc-3. We have made enough progress with the other packages to allow me to do this. Thanks!

Comment 5 Robert-André Mauchin 🐧 2023-09-25 19:53:43 UTC
Package approved.

Comment 6 Fedora Admin user for bugzilla script actions 2023-09-26 01:53:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-ccgo-4

Comment 7 Fedora Update System 2023-10-03 21:15:20 UTC
FEDORA-2023-730b1fd5fc has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-730b1fd5fc

Comment 8 Fedora Update System 2023-10-03 21:16:09 UTC
FEDORA-2023-730b1fd5fc has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.