Bug 223490 - Review Request: alex - The lexer generator for Haskell
Review Request: alex - The lexer generator for Haskell
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jens Petersen
Fedora Package Reviews List
:
Depends On: 223486
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-19 13:08 EST by Bryan O'Sullivan
Modified: 2014-04-14 01:00 EDT (History)
1 user (show)

See Also:
Fixed In Version: 2.1.0-5.fc7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-10 00:59:37 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
petersen: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)
alex.spec-2-fixes.patch (1.17 KB, patch)
2007-06-25 01:26 EDT, Jens Petersen
no flags Details | Diff

  None (edit)
Description Bryan O'Sullivan 2007-01-19 13:08:04 EST
Spec URL: http://www.red-bean.com/~bos/alex.spec
SRPM URL: http://www.red-bean.com/~bos/alex-2.1.0-1.src.rpm
Description:
Alex is a tool for generating lexical analysers in Haskell, given a
description of the tokens to be recognised in the form of regular
expressions.  It is similar to the tool lex or flex for C/C++.

[I am a new contributor, and need a sponsor.]
Comment 1 Jens Petersen 2007-02-21 20:43:16 EST
Basically this package also looks ok.
I might suggest some minor cleanup of the .spec along the lines of happy.spec.
Comment 2 Bryan O'Sullivan 2007-03-26 22:51:37 EDT
I'll clean this up later this evening and point you at the results.
Comment 3 Bryan O'Sullivan 2007-04-26 13:16:44 EDT
Well, that took a while to get around to :-)

Spec URL: http://www.red-bean.com/~bos/alex.spec
SRPM URL: http://www.red-bean.com/~bos/alex-2.1.0-2.src.rpm
Comment 4 Jens Petersen 2007-06-25 01:18:07 EDT
Sorry for sitting on this so long.

(In reply to comment #3)
> SRPM URL: http://www.red-bean.com/~bos/alex-2.1.0-2.src.rpm

(BTW this links seems to be broken.)

Thanks for cleaning up - the rpmlint output is clean. :)


Comment 5 Jens Petersen 2007-06-25 01:26:22 EDT
Created attachment 157731 [details]
alex.spec-2-fixes.patch

simplify buildrequires and build:
- happy, docbook-dtds, libxml2, xmltex not needed as buildrequires afaict
Comment 6 Jens Petersen 2007-07-20 04:05:38 EDT
ping
Comment 7 Bryan O'Sullivan 2007-07-22 12:32:12 EDT
Jens, I've applied your patch with one change (still need to run autoreconf
before ./configure in the doc directory).  Thanks!

This should be the final version of the package, I believe.

http://www.red-bean.com/~bos/alex-2.1.0-3.fc7.src.rpm
http://www.red-bean.com/~bos/alex.spec
Comment 8 Jens Petersen 2007-07-22 21:47:08 EDT
Here is the formal review:

Good:
+ rpmlint clean
+ license is BSD
+ checked source md5sum:
17e80d39cc3f1aba28dcea0e358c81e9  alex-2.1.0.tar.gz
+ directory ownership good

Needs attention:
- need to exclude ppc64 for this too I guess.

All other MUST items are satisfied.

Could you please add the ppc64 excludes and open a bug for that making it depend
on the ghc ppc64 bug.

Package is APPROVED.
Comment 9 Jens Petersen 2007-09-25 01:13:54 EDT
PING

This is still not built, right?
Comment 10 Jens Petersen 2007-09-25 01:14:26 EDT
Could you please put in a cvsadmin request?
Comment 11 Bryan O'Sullivan 2007-09-25 12:22:34 EDT
New Package CVS Request
=======================
Package Name: alex
Short Description: A tool for generating lexical analysers in Haskell
Owners: bos, petersen
Branches: F-7
InitialCC: 
Cvsextras Commits: yes
Comment 12 Kevin Fenzi 2007-09-25 14:24:26 EDT
cvs done.
Comment 13 Bryan O'Sullivan 2007-09-25 18:26:19 EDT
koji is choking due to ppc and ppc64 build failures.  What should I do about this?

http://koji.fedoraproject.org/koji/taskinfo?taskID=174765
Comment 14 Jens Petersen 2007-09-25 20:16:48 EDT
Koji has been a bit unstable recently, please try again later after excluding
ppc64 until ghc is available there. (It would be good to file a bug to track
that too.)
Comment 15 Fedora Update System 2007-10-03 17:17:35 EDT
alex-2.1.0-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update alex'
Comment 16 Fedora Update System 2007-11-10 00:59:36 EST
alex-2.1.0-5.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Jens Petersen 2010-10-05 00:32:10 EDT
Package Change Request
======================
Package Name: alex
New Branches: el6
Owners: bos petersen
InitialCC: haskell-sig
Comment 18 Jason Tibbitts 2010-10-05 09:32:28 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.