Bug 2235067 (python-intbitset) - Review Request: python-intbitset - Python C-based extension implementing fast integer bit sets
Summary: Review Request: python-intbitset - Python C-based extension implementing fast...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: python-intbitset
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/inveniosoftware-co...
Whiteboard:
Depends On:
Blocks: scancode-toolkit
TreeView+ depends on / blocked
 
Reported: 2023-08-26 11:22 UTC by Robert-André Mauchin 🐧
Modified: 2023-11-05 05:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-05 05:38:25 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6528289 to 6557798 (553 bytes, patch)
2023-10-23 13:12 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6557798 to 6558507 (1.02 KB, patch)
2023-10-23 16:47 UTC, Fedora Review Service
no flags Details | Diff

Description Robert-André Mauchin 🐧 2023-08-26 11:22:39 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset-3.0.2-1.fc38.src.rpm

Description:
The intbitset library provides a set implementation to store sorted unsigned integers either 32-bits integers (between 0 and 2**31 - 1 or intbitset.__maxelem__) or an infinite range with fast set operations implemented via bit vectors in a Python C extension for speed and reduced memory usage.  The inbitset class emulates the Python built-in set class interface with some additional specific methods such as its own fast dump and load marshalling functions.

Fedora Account System Username: eclipseo

To build it against the dependencies, use the following COPR in your rawhide mock.cfg:

[copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit]
name=Copr repo for scancode-toolkit owned by eclipseo
baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Benson Muite 2023-10-01 15:17:24 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.rst.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 3", "GNU Lesser General Public License v3.0 or later [obsolete
     FSF postal address (Temple Place)]", "MIT License". 11 files have
     unknown license. Detailed output of licensecheck in
     /home/FedoraPackaging/reviews/python-intbitset/2235067-python-
     intbitset/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 16490 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-intbitset
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-intbitset-3.0.2-1.fc38.x86_64.rpm
          python-intbitset-doc-3.0.2-1.fc38.noarch.rpm
          python-intbitset-debugsource-3.0.2-1.fc38.x86_64.rpm
          python-intbitset-3.0.2-1.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpo7y6soeo')]
checks: 31, packages: 4

python-intbitset-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python-intbitset-doc/html/_sources/license.rst.txt
python3-intbitset.x86_64: E: incorrect-fsf-address /usr/lib64/python3.11/site-packages/intbitset_helper.py
python3-intbitset.x86_64: E: incorrect-fsf-address /usr/lib64/python3.11/site-packages/intbitset_version.py
 4 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 badness; has taken 5.7 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

python-intbitset-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python-intbitset-doc/html/_sources/license.rst.txt
python3-intbitset.x86_64: E: incorrect-fsf-address /usr/lib64/python3.11/site-packages/intbitset_helper.py
python3-intbitset.x86_64: E: incorrect-fsf-address /usr/lib64/python3.11/site-packages/intbitset_version.py
 3 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 badness; has taken 1.4 s 



Unversioned so-files
--------------------
python3-intbitset: /usr/lib64/python3.11/site-packages/intbitset.cpython-311-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/inveniosoftware-contrib/intbitset/archive/v3.0.2/intbitset-3.0.2.tar.gz :
  CHECKSUM(SHA256) this package     : d08c2e9d8d17dc8bbe2d76e79e08fc6977585c83d4e07bf8a9e70673f196c993
  CHECKSUM(SHA256) upstream package : d08c2e9d8d17dc8bbe2d76e79e08fc6977585c83d4e07bf8a9e70673f196c993


Requires
--------
python3-intbitset (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-intbitset-doc (rpmlib, GLIBC filtered):

python-intbitset-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-intbitset:
    python-intbitset
    python3-intbitset
    python3-intbitset(x86-64)
    python3.11-intbitset
    python3.11dist(intbitset)
    python3dist(intbitset)

python-intbitset-doc:
    python-intbitset-doc

python-intbitset-debugsource:
    python-intbitset-debugsource
    python-intbitset-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2235067 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Shell-api, Python, Generic, C/C++
Disabled plugins: PHP, Ruby, Java, fonts, Haskell, SugarActivity, Ocaml, Perl, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Cython should be run in the build section, not in the prep section
b) Remove pregenerated c file in the prep section, this is src/intbitset.c
c) dist-info folder contains README.rst, AUTHORS.rst and CHANGELOG.rst so do not need to mark these
as documentation files
d) rpm -qL python3-intbitset-3.0.2-1.fc38.x86_64.rpm
gives:
/usr/lib64/python3.11/site-packages/intbitset-3.0.2.dist-info/AUTHORS.rst
/usr/lib64/python3.11/site-packages/intbitset-3.0.2.dist-info/CHANGELOG.rst
/usr/lib64/python3.11/site-packages/intbitset-3.0.2.dist-info/LICENSE
/usr/lib64/python3.11/site-packages/intbitset-3.0.2.dist-info/README.rst
/usr/share/licenses/python3-intbitset/LICENSE
so no need to mark the LICENSE file as %license because the one in dist-info
has the correct metadata.
e) Doc package has bundled js-jquery and js-underscore. Please indicate this in the spec file.
f) Does not build on s390x:
https://koji.fedoraproject.org/koji/taskinfo?taskID=106956624

Comment 2 Robert-André Mauchin 🐧 2023-10-15 18:58:49 UTC
> e) Doc package has bundled js-jquery and js-underscore. Please indicate this in the spec file.

Can´t find that at all.


Spec URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset-3.0.2-1.fc39.src.rpm

Thanks for the review!

Comment 3 Fedora Review Service 2023-10-15 19:05:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6528289
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235067-python-intbitset/fedora-rawhide-x86_64/06528289-python-intbitset/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Benson Muite 2023-10-16 08:54:28 UTC
- Package must not depend on deprecated() packages.
  Note: python3-cython0.29 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/

Can:
BuildRequires:  python3-Cython
be replaced by:
BuildRequires:  cython

See:
https://src.fedoraproject.org/rpms/Cython

Comment 6 Fedora Review Service 2023-10-23 13:12:02 UTC
Created attachment 1995169 [details]
The .spec file difference from Copr build 6528289 to 6557798

Comment 7 Fedora Review Service 2023-10-23 13:12:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6557798
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235067-python-intbitset/fedora-rawhide-x86_64/06557798-python-intbitset/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Benson Muite 2023-10-23 14:07:40 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package must not depend on deprecated() packages.
  Note: python3-cython0.29 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.rst.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 3", "GNU Lesser General Public License v3.0 or later [obsolete
     FSF postal address (Temple Place)]", "MIT License". 11 files have
     unknown license. Detailed output of licensecheck in
     /home/fedora/2235067-python-intbitset/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-intbitset
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-intbitset-3.0.2-1.fc40.aarch64.rpm
          python-intbitset-doc-3.0.2-1.fc40.noarch.rpm
          python-intbitset-debugsource-3.0.2-1.fc40.aarch64.rpm
          python-intbitset-3.0.2-1.fc40.src.rpm
======================================= rpmlint session starts =======================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp47ikoy__')]
checks: 31, packages: 4

python3-intbitset.aarch64: W: no-documentation
python-intbitset-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python-intbitset-doc/html/_sources/license.rst.txt
python3-intbitset.aarch64: E: incorrect-fsf-address /usr/lib64/python3.12/site-packages/intbitset_helper.py
python3-intbitset.aarch64: E: incorrect-fsf-address /usr/lib64/python3.12/site-packages/intbitset_version.py
======== 4 packages and 0 specfiles checked; 3 errors, 1 warnings, 3 badness; has taken 0.3 s ========




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

python3-intbitset.aarch64: W: no-documentation
python3-intbitset.aarch64: E: incorrect-fsf-address /usr/lib64/python3.12/site-packages/intbitset_helper.py
python3-intbitset.aarch64: E: incorrect-fsf-address /usr/lib64/python3.12/site-packages/intbitset_version.py
python-intbitset-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python-intbitset-doc/html/_sources/license.rst.txt
 3 packages and 0 specfiles checked; 3 errors, 1 warnings, 3 badness; has taken 0.2 s 



Unversioned so-files
--------------------
python3-intbitset: /usr/lib64/python3.12/site-packages/intbitset.cpython-312-aarch64-linux-gnu.so

Source checksums
----------------
https://github.com/inveniosoftware-contrib/intbitset/archive/v3.0.2/intbitset-3.0.2.tar.gz :
  CHECKSUM(SHA256) this package     : d08c2e9d8d17dc8bbe2d76e79e08fc6977585c83d4e07bf8a9e70673f196c993
  CHECKSUM(SHA256) upstream package : d08c2e9d8d17dc8bbe2d76e79e08fc6977585c83d4e07bf8a9e70673f196c993


Requires
--------
python3-intbitset (rpmlib, GLIBC filtered):
    ld-linux-aarch64.so.1()(64bit)
    libc.so.6()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-intbitset-doc (rpmlib, GLIBC filtered):

python-intbitset-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-intbitset:
    python-intbitset
    python3-intbitset
    python3-intbitset(aarch-64)
    python3.12-intbitset
    python3.12dist(intbitset)
    python3dist(intbitset)

python-intbitset-doc:
    python-intbitset-doc

python-intbitset-debugsource:
    python-intbitset-debugsource
    python-intbitset-debugsource(aarch-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2235067
Buildroot used: fedora-rawhide-aarch64
Active plugins: C/C++, Python, Generic, Shell-api
Disabled plugins: Ocaml, PHP, Perl, SugarActivity, fonts, Java, Haskell, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) searchtools.js and most other javascript files in the documentation package are under BSD license
b) Cython warning happens with every Cython package in Fedora. Seems like a bug in Fedora-review,
perhaps revert to
BuildRequires: Cython
as this is the most update one
https://src.fedoraproject.org/rpms/Cython

Comment 9 Robert-André Mauchin 🐧 2023-10-23 16:32:31 UTC
this was fixed this week-end but apparently I didn't rsync the changes correctly:


Spec URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-intbitset-3.0.2-1.fc39.src.rpm



We have:

%package -n python-%{pypi_name}-doc
Summary:        Documentation for python-%{pypi_name}
# BSD-2-Clause: Sphinx javascript
# MIT: jquery
License:        LGPL-3.0-or-later AND BSD-2-Clause AND MIT
BuildArch:      noarch
Requires:       python3-%{pypi_name} = %{?epoch:%{epoch}:}%{version}-%{release}
Provides:       bundled(js-sphinx_javascript_frameworks_compat)
Provides:       bundled(js-doctools)
Provides:       bundled(js-jquery)
Provides:       bundled(js-language_data)
Provides:       bundled(js-searchtools)


And

BuildRequires:  Cython

BuildRequires:  cython

Comment 10 Fedora Review Service 2023-10-23 16:47:05 UTC
Created attachment 1995210 [details]
The .spec file difference from Copr build 6557798 to 6558507

Comment 11 Fedora Review Service 2023-10-23 16:47:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6558507
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235067-python-intbitset/fedora-rawhide-x86_64/06558507-python-intbitset/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Benson Muite 2023-10-23 21:57:18 UTC
Approved.

Comment 13 Robert-André Mauchin 🐧 2023-10-24 17:11:50 UTC
Thanks again!

Comment 14 Fedora Admin user for bugzilla script actions 2023-10-24 17:12:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-intbitset

Comment 15 Miroslav Suchý 2023-11-05 05:38:25 UTC
Package is now built for all stable Fedoras. https://koji.fedoraproject.org/koji/packageinfo?packageID=38760


Note You need to log in before you can comment on or make changes to this bug.