Spec URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit-32.0.6-1.fc38.src.rpm Description: ScanCode is an open-source tool to scan code and detect licenses, copyrights, and more. It provides detailed information about discovered licenses, copyrights, and other important details in various formats. Fedora Account System Username: eclipseo To build it against the dependencies, use the following COPR in your rawhide mock.cfg: [copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit] name=Copr repo for scancode-toolkit owned by eclipseo baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-/ type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
Copr build: https://copr.fedorainfracloud.org/coprs/build/6345534 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235055-scancode-toolkit/fedora-rawhide-x86_64/06345534-scancode-toolkit/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Deps need to be packaged first No matching package to install: 'python3dist(commoncode) >= 31.0.2' No matching package to install: 'python3dist(container-inspector) >= 31' No matching package to install: 'python3dist(debian-inspector) >= 31' No matching package to install: 'python3dist(dparse2) >= 0.7' No matching package to install: 'python3dist(extractcode) >= 31' No matching package to install: 'python3dist(extractcode[full]) >= 31' No matching package to install: 'python3dist(fingerprints) >= 0.6' No matching package to install: 'python3dist(ftfy) >= 6' No matching package to install: 'python3dist(gemfileparser2) >= 0.9' No matching package to install: 'python3dist(intbitset) >= 3.0.2' No matching package to install: 'python3dist(jsonstreams) >= 0.5' No matching package to install: 'python3dist(license-expression) >= 30.1.1' No matching package to install: 'python3dist(packageurl-python) >= 0.9' No matching package to install: 'python3dist(packvers) >= 21' No matching package to install: 'python3dist(parameter-expansion-patched) >= 0.3.1' No matching package to install: 'python3dist(pip-requirements-parser) >= 32.0.1' No matching package to install: 'python3dist(pkginfo2) >= 30' No matching package to install: 'python3dist(plugincode) >= 32' No matching package to install: 'python3dist(pyahocorasick) >= 2' No matching package to install: 'python3dist(pygmars) >= 0.7' No matching package to install: 'python3dist(pymaven-patch) >= 0.2.8' No matching package to install: 'python3dist(saneyaml) >= 0.6' No matching package to install: 'python3dist(typecode) >= 30.0.1' No matching package to install: 'python3dist(typecode[full]) >= 30.0.1' No matching package to install: 'python3dist(urlpy)'
Spec URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit-32.0.8-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6548905 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235055-scancode-toolkit/fedora-rawhide-x86_64/06548905-scancode-toolkit/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Every deps is now packaged, anyone up for the review? Thank you.
Ouch, I was under assumption that the deps are not yet packages as the related bugzillas were still open. I will proceed. Hmmm, bumper: No matching package to install: 'python3dist(license-expression) >= 30.1.1' I am comaintainer for that packages. I will try to rebase it.
The license-expression 30.1.1 is finally in rawhide. So the build get past deps installation, but eventually fail on tests: =========================== short test summary info ============================ FAILED tests/formattedcode/test_output_spdx.py::test_spdx_rdf_basic - assert ... XFAIL tests/cluecode/test_finder.py::TestUrl::test_misc_valid_unicode_or_punycode_urls_that_should_pass - reason: XFAIL tests/cluecode/test_finder.py::TestUrl::test_misc_valid_urls_that_should_pass - reason: XFAIL tests/textcode/test_pdf.py::TestPdf::test_numbered_text_lines_does_not_fail_on_autocad_test_pdf - Latest pdfminer.six from 2022 has a regression = 1 failed, 2684 passed, 1 skipped, 45243 deselected, 3 xfailed, 4000 warnings in 438.23s (0:07:18) = And the whole build fails.
Ping? How it is going?
Gentle ping here. Or is there any blocker?
At the moment, mock from f39 bails out for both -rawhide and -40 (but seems unrelated dnf5): $ mock -r /etc/mock/fedora-rawhide-x86_64.cfg rebuild /home/media/media_disk/dev/scancode-toolkit/scancode-toolkit-32.0.8-1.fc39.src.rpm ... Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) INFO: Buildroot is handled by package management downloaded with a bootstrap image: rpm-4.17.0-1.fc36.1.x86_64 python3-dnf-4.10.0-1.fc36.noarch python3-dnf-plugins-core-4.0.24-1.fc36.noarch Start: installing minimal buildroot with dnf5 execv(/usr/bin/dnf5) failed: No such file or directory ERROR: Exception(/home/media/media_disk/dev/scancode-toolkit/scancode-toolkit-32.0.8-1.fc39.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 2 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-x86_64/result ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 1f94d65f6514446b87cf2e1319ef738c -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.xp4chj56:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 40 install @buildsys-build --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts execv(/usr/bin/dnf5) failed: No such file or directory
mock -r fedora-rawhide-x86_64 --scrub=all will fix that.
Gentle ping. I am looking forward to see this package in Fedora.
Ping. Can we proceed? Or should somebody else continue? I tested the original src.rpm and it still fails with the same tests failures.
*** Bug 2283259 has been marked as a duplicate of this bug. ***
*** Bug 2283258 has been marked as a duplicate of this bug. ***
Update https://copr.fedorainfracloud.org/coprs/eclipseo/scancode-toolkit/build/7491323/ Spec URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit-32.1.0-1.fc40.src.rpm Needs a new spdx-tools.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7492447 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235055-scancode-toolkit/fedora-rawhide-x86_64/07492447-scancode-toolkit/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The summary should not end with a dot. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections The patch should have linked the upstream issue or commented on why it was added. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ Otherwise, it looks good. Please build new spdx-tools in rawhide and update the above nitpicks and I will approve.
*** Bug 2283260 has been marked as a duplicate of this bug. ***
Spec URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/scancode-toolkit-32.0.6-1.fc38.src.rpm I have addressed your points. The patch is downstream only to remove some extra theme for the docs. spdx-tools depends on 2283281 being reviewed and packaged.
All resolved. APPROVED. You are an experienced maintainer, so please build this one only after you finish with bug 2283281
The Pagure repository was created at https://src.fedoraproject.org/rpms/scancode-toolkit
FEDORA-2024-f26252b1fb (scancode-toolkit-32.1.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f26252b1fb
FEDORA-2024-f26252b1fb has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f26252b1fb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f26252b1fb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-1eff6397d9 (scancode-toolkit-32.2.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.