Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-32.0.1-1.fc38.src.rpm Description: This is an experimental Python library to enable POSIX parameter expansion in a string. It supports also a subset of Bash parameter expansion. Fedora Account System Username: eclipseo To build it against the dependencies, use the following COPR in your rawhide mock.cfg: [copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit] name=Copr repo for scancode-toolkit owned by eclipseo baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-/ type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
It seems that the description is, by mistake, copied from python-parameter-expansion-patched. And the -doc subpackage should contains: Provides: bundled(jquery) Provides: bundled(js-searchtools) Otherwise LGTM.
> It seems that the description is, by mistake, copied from python-parameter-expansion-patched. fixed > And the -doc subpackage should contains: > Provides: bundled(jquery) > Provides: bundled(js-searchtools) ok Thanks for the review. Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-32.0.1-1.fc39.src.rpm
The "Provides" should go to -doc package. I.e. %package -n python-%{pypi_name}-doc Summary: Documentation for python-%{pypi_name} BuildArch: noarch Provides: bundled(jquery) Provides: bundled(js-searchtools)
Copr build: https://copr.fedorainfracloud.org/coprs/build/6532612 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235075-python-pip-requirements-parser/fedora-rawhide-x86_64/06532612-python-pip-requirements-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Miroslav Suchý from comment #3) > The "Provides" should go to -doc package. I.e. > > %package -n python-%{pypi_name}-doc > Summary: Documentation for python-%{pypi_name} > BuildArch: noarch > Provides: bundled(jquery) > Provides: bundled(js-searchtools) Done. Thank you. Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-32.0.1-1.fc39.src.rpm
Is it possible that you forgot to upload the altered spec and src.rpm? I still see the provides in main package. And I double check I am not seeing cached version.
Update this way: %package -n python-%{pypi_name}-doc Summary: Documentation for python-%{pypi_name} # BSD-2-Clause: Sphinx javascript # MIT: jquery License: MIT AND BSD-2-Clause BuildArch: noarch Requires: python3-%{pypi_name} = %{?epoch:%{epoch}:}%{version}-%{release} Provides: bundled(js-sphinx_javascript_frameworks_compat) Provides: bundled(js-doctools) Provides: bundled(js-jquery) Provides: bundled(js-language_data) Provides: bundled(js-searchtools) Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pip-requirements-parser-32.0.1-1.fc39.src.rpm
APPROVED
Thank you so much!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pip-requirements-parser
FEDORA-2023-3aa6ce0b7e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3aa6ce0b7e
FEDORA-2023-67d1d7288b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-67d1d7288b
FEDORA-2023-3aa6ce0b7e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3aa6ce0b7e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3aa6ce0b7e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-67d1d7288b has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-67d1d7288b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-67d1d7288b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-3aa6ce0b7e has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-67d1d7288b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.