Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pygmars.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pygmars-0.8.0-1.fc38.src.rpm Description: pygmars is a simple lexing and parsing library designed to craft lightweight lexers and parsers using regular expressions. pygmars allows you to craft simple lexers that recognizes words based on regular expressions and identify sequences of words using lightweight grammars to obtain a parse tree. The lexing task transforms a sequence of words or strings (e.g. already split in words) in a sequence of Token objects, assigning a label to each word and tracking their position and line number. In particular, the lexing output is designed to be compatible with the output of Pygments lexers. It becomes possible to build simple grammars on top of existing Pygments lexers to perform lightweight parsing of the many (130+) programming languages supported by Pygments. The parsing task transforms a sequence of Tokens in a parse Tree where each node in the tree is recognized and assigned a label. Parsing is using regular expression-based grammar rules applied to recognize Token sequences. These rules are evaluated sequentially and not recursively: this keeps things simple and works very well in practice. This approach and the rules syntax has been battle-tested with NLTK from which pygmars is derived. Fedora Account System Username: eclipseo To build it against the dependencies, use the following COPR in your rawhide mock.cfg: [copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit] name=Copr repo for scancode-toolkit owned by eclipseo baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-/ type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* MIT License", "BSD 2-Clause with views sentence", "MIT License BSD 2-Clause with views sentence". 35 files have unknown license. Detailed output of licensecheck in /home/fedora/reviews/python-pygmars/2235079-python- pygmars/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 18071 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pygmars [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pygmars-0.8.0-1.fc38.noarch.rpm python-pygmars-doc-0.8.0-1.fc38.noarch.rpm python-pygmars-0.8.0-1.fc38.src.rpm ================================= rpmlint session starts ================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptv_zpmhm')] checks: 31, packages: 3 == 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 6.7 s = Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://github.com/nexB/pygmars/archive/v0.8.0/pygmars-0.8.0.tar.gz : CHECKSUM(SHA256) this package : d701700cff1960e5fdff3e8b6f569b49746780cd782da8b06486924f287574c5 CHECKSUM(SHA256) upstream package : d701700cff1960e5fdff3e8b6f569b49746780cd782da8b06486924f287574c5 Requires -------- python3-pygmars (rpmlib, GLIBC filtered): python(abi) python-pygmars-doc (rpmlib, GLIBC filtered): Provides -------- python3-pygmars: python-pygmars python3-pygmars python3.11-pygmars python3.11dist(pygmars) python3dist(pygmars) python-pygmars-doc: python-pygmars-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2235079 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Perl, Ruby, SugarActivity, Java, fonts, Ocaml, PHP, Haskell, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Notice and LICENSE files are automatically marked in the metadata, so no need to have %license NOTICE %license apache-2.0.LICENSE in the main package $ rpm -qL python3-pygmars-0.8.0-1.fc38.noarch.rpm /usr/lib/python3.11/site-packages/pygmars-0.8.0.dist-info/AUTHORS.rst /usr/lib/python3.11/site-packages/pygmars-0.8.0.dist-info/CHANGELOG.rst /usr/lib/python3.11/site-packages/pygmars-0.8.0.dist-info/NOTICE /usr/lib/python3.11/site-packages/pygmars-0.8.0.dist-info/apache-2.0.LICENSE /usr/share/licenses/python3-pygmars/NOTICE /usr/share/licenses/python3-pygmars/apache-2.0.LICENSE b) Documentation build tries to fetch online content. Can this be avoided? c) Documentation has a number of bundled javascript libraries such as jquery, can the spec file indicate these are bundled? Alternatively, consider generating man pages or another documentation format that does not bundle extra content. d) Is sphinx-rtd-theme required?
> c) Documentation has a number of bundled javascript libraries such as jquery, can the spec file indicate these are bundled? There's only jquery so I added Provides: bundled(js-jquery) > Alternatively, consider generating man pages or another documentation format that does not bundle extra content. We´ŕe not gonna stop providing html doc because sphinx bundles jquery I think.This has always be the case and PDF doc is way less pratical. > d) Is sphinx-rtd-theme required? Why? This is packaged for Fedora and this is how the author wants, why would we get rid of it, I don't understand. Thank you the review. Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pygmars.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pygmars-0.8.0-1.fc39.src.rpm
Added: %package -n python-%{pypi_name}-doc Summary: Documentation for python-%{pypi_name} BuildArch: noarch # BSD-2-Clause: Sphinx javascript # MIT: jquery License: Apache-2.0 AND BSD-2-Clause AND MIT BuildArch: noarch Requires: python3-%{pypi_name} = %{?epoch:%{epoch}:}%{version}-%{release} Provides: bundled(js-sphinx_javascript_frameworks_compat) Provides: bundled(js-doctools) Provides: bundled(js-jquery) Provides: bundled(js-language_data) Provides: bundled(js-searchtools)
Current spec file has duplicate arch entries for the doc package.
Fixed.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "MIT License", "*No copyright* MIT License", "BSD 2-Clause with views sentence", "MIT License BSD 2-Clause with views sentence". 35 files have unknown license. Detailed output of licensecheck in /home/fedora/reviews/2235079-python- pygmars/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9993 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pygmars [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pygmars-0.8.0-1.fc40.noarch.rpm python-pygmars-doc-0.8.0-1.fc40.noarch.rpm python-pygmars-0.8.0-1.fc40.src.rpm ================================== rpmlint session starts ================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwmp_z19h')] checks: 31, packages: 3 python-pygmars.spec:59: W: unversioned-explicit-provides bundled(js-sphinx_javascript_frameworks_compat) python-pygmars.spec:60: W: unversioned-explicit-provides bundled(js-doctools) python-pygmars.spec:61: W: unversioned-explicit-provides bundled(js-jquery) python-pygmars.spec:62: W: unversioned-explicit-provides bundled(js-language_data) python-pygmars.spec:63: W: unversioned-explicit-provides bundled(js-searchtools) === 3 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.3 s === Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/nexB/pygmars/archive/v0.8.0/pygmars-0.8.0.tar.gz : CHECKSUM(SHA256) this package : d701700cff1960e5fdff3e8b6f569b49746780cd782da8b06486924f287574c5 CHECKSUM(SHA256) upstream package : d701700cff1960e5fdff3e8b6f569b49746780cd782da8b06486924f287574c5 Requires -------- python3-pygmars (rpmlib, GLIBC filtered): python(abi) python-pygmars-doc (rpmlib, GLIBC filtered): python3-pygmars Provides -------- python3-pygmars: python-pygmars python3-pygmars python3.12-pygmars python3.12dist(pygmars) python3dist(pygmars) python-pygmars-doc: bundled(js-doctools) bundled(js-jquery) bundled(js-language_data) bundled(js-searchtools) bundled(js-sphinx_javascript_frameworks_compat) python-pygmars-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2235079 Buildroot used: fedora-rawhide-aarch64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, C/C++, PHP, Ocaml, fonts, Java, Haskell, SugarActivity, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Can remove %doc CHANGELOG.rst as CHANGELOG.rst is packaged with the python files. Not sure if CODE_OF_CONDUCT.rst needs to be packaged, but upto you. So would just have either: %doc CODE_OF_CONDUCT.rst README.rst or %doc README.rst b) Please fix above on import. Approve.
Fixed. Thank you for the review Benson!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pygmars
FEDORA-2023-eafb780753 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-eafb780753
FEDORA-2023-fb9e4917fe has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fb9e4917fe
FEDORA-2023-64754a94ab has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-64754a94ab
FEDORA-2023-eafb780753 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-eafb780753 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-eafb780753 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-64754a94ab has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-64754a94ab \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-64754a94ab See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-fb9e4917fe has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fb9e4917fe \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fb9e4917fe See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-64754a94ab has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-eafb780753 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-fb9e4917fe has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.