Bug 2235244 - webUI: uses Firefox icon (and a window title with Mozilla Firefox in it) in the overview
Summary: webUI: uses Firefox icon (and a window title with Mozilla Firefox in it) in t...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 39
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: anaconda-maint
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: AnacondaWebUITracker F39BetaFreezeException
TreeView+ depends on / blocked
 
Reported: 2023-08-28 06:43 UTC by Adam Williamson
Modified: 2023-09-08 20:25 UTC (History)
4 users (show)

Fixed In Version: anaconda-39.32.2-1.fc39
Clone Of:
Environment:
Last Closed: 2023-09-08 20:25:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github rhinstaller anaconda pull 5112 0 None Draft Use Firefox environment variables for styling 2023-09-06 15:26:07 UTC

Description Adam Williamson 2023-08-28 06:43:43 UTC
The webUI installer has the Firefox icon in the overview, which is rather confusing. It also has a window title with "Mozilla Firefox" in it.

In https://bugzilla.redhat.com/show_bug.cgi?id=2231073#c3 , Martin Stransky says:

"In firefox-116.0.2-2.fc39 you can set MOZ_APP_REMOTINGNAME env variable which overrides default application name exported to system. Run as:

MOZ_APP_REMOTINGNAME="anaconda" firefox

You also need to install proper desktop file (/usr/share/applications/anaconda.desktop):

```
[Desktop Entry]
Version=1.0
Name=Anaconda
GenericName=Anaconda Installer
Comment=Install it!
Exec=anaconda
Icon=org.fedoraproject.AnacondaInstaller
Terminal=false
Type=Application
StartupNotify=true
```

You also need to create /usr/bin/anaconda launcher where you set all env variables etc."

This mechanism seems like it could address both the icon and window title issues. We already have https://bugzilla.redhat.com/show_bug.cgi?id=2230336 for the window title issue, so there is some confusing overlap here; two solutions have been mooted for that. One by Martin is the use of a MOZ_APP_TITLE env var, as described at https://bugzilla.redhat.com/show_bug.cgi?id=2230336#c3 . Another by halfline is using client side decorations, as per https://github.com/rhinstaller/anaconda/pull/5057 - but this may only address the title seen in the webUI window's header bar, it may not address the title used on the overview.

I'm guessing we might ultimately want to have both halfline's PR *and* a change to use MOZ_APP_REMOTINGNAME, so the window title is addressed both in the window header and the overview, and the icon used in the overview is also addressed.

Proposing as a Beta FE as a polish issue we ought to address for Beta if we can.

Reproducible: Always

Comment 1 Adam Williamson 2023-08-28 06:44:35 UTC
Sigh. I meant "we already have https://bugzilla.redhat.com/show_bug.cgi?id=2230058 for the window title issue", not 2230336.

Comment 2 Adam Williamson 2023-08-28 15:22:31 UTC
+4 in https://pagure.io/fedora-qa/blocker-review/issue/1211 , marking accepted.

Comment 3 Adam Williamson 2023-08-28 15:23:14 UTC
Also note that per https://bugzilla.redhat.com/show_bug.cgi?id=2230336#c7 , we might need MOZ_APP_TITLE *and* MOZ_APP_REMOTINGNAME (and also halfline's PR if we want to 'hide' the window header title entirely rather than just change it).

Comment 4 Fedora Update System 2023-09-07 15:48:40 UTC
FEDORA-2023-755dc0b0c0 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-755dc0b0c0

Comment 5 Adam Williamson 2023-09-07 23:33:12 UTC
Confirmed fixed, the icon is correct and the title is "Install to Hard Drive".

Comment 6 Fedora Update System 2023-09-08 01:37:03 UTC
FEDORA-2023-755dc0b0c0 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-755dc0b0c0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-755dc0b0c0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-09-08 20:25:25 UTC
FEDORA-2023-755dc0b0c0 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.