Spec URL: https://carlwgeorge.fedorapeople.org/packaging/python-watchfiles/python-watchfiles.spec SRPM URL: https://carlwgeorge.fedorapeople.org/packaging/python-watchfiles/python-watchfiles-0.20.0-1.fc40.src.rpm Description: Simple, modern and high performance file watching and code reload in python. Underlying file system notifications are handled by the Notify rust library. Fedora Account System Username: carlwgeorge
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora-rawhide- aarch64/root/builddir/build/BUILD/watchfiles-0.20.0' returned non-zero exit status 2. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-watchfiles [ ]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-watchfiles-0.20.0-1.fc40.aarch64.rpm python-watchfiles-debugsource-0.20.0-1.fc40.aarch64.rpm python-watchfiles-0.20.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_wq3xskw')] checks: 31, packages: 3 python3-watchfiles.aarch64: W: no-manual-page-for-binary watchfiles 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_BaseException (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_ImportError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyBool_Type (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_OSError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_ValueError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_SystemError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_TypeError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyBaseObject_Type (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so _Py_TrueStruct (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_RuntimeError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_PermissionError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so _Py_NoneStruct (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_AttributeError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyExc_FileNotFoundError (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyType_GenericAlloc (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyUnicode_AsEncodedString (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyException_SetCause (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyIter_Next (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyGILState_Release (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyBytes_Size (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyException_GetCause (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_IsTrue (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_GivenExceptionMatches (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_Str (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_GetItem (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyDict_Next (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_GetAttr (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyEval_RestoreThread (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_WriteUnraisable (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyBytes_AsString (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyType_FromSpec (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyEval_SaveThread (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyDict_Size (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_Restore (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_SetItem (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PySequence_Size (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_GetIter (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyType_IsSubtype (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_NewExceptionWithDoc (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyGILState_Ensure (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_NormalizeException (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyType_GetFlags (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_Fetch (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PySequence_Check (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PySet_Add (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_SetAttrString (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyList_Append (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_SetAttr (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_CheckSignals (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyType_GetSlot (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_Call (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_Print (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyLong_FromLong (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyLong_AsUnsignedLongLong (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_DelItem (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PySet_New (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyException_SetTraceback (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so _Py_Dealloc (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyTuple_Size (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyModule_Create2 (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyTuple_New (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyTuple_SetItem (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyTuple_GetItem (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyLong_FromSsize_t (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyUnicode_FromStringAndSize (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyList_New (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyCallable_Check (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyErr_PrintEx (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyUnicode_AsUTF8String (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyUnicode_InternInPlace (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so Py_IsInitialized (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyNumber_Index (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyObject_Repr (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so PyException_GetTraceback (/usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so) python3-watchfiles.aarch64: W: no-manual-page-for-binary watchfiles 2 packages and 0 specfiles checked; 0 errors, 75 warnings, 0 badness; has taken 0.2 s Unversioned so-files -------------------- python3-watchfiles: /usr/lib64/python3.12/site-packages/watchfiles/_rust_notify.abi3.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/w/watchfiles/watchfiles-0.20.0.tar.gz : CHECKSUM(SHA256) this package : 728575b6b94c90dd531514677201e8851708e6e4b5fe7028ac506a200b622019 CHECKSUM(SHA256) upstream package : 728575b6b94c90dd531514677201e8851708e6e4b5fe7028ac506a200b622019 Requires -------- python3-watchfiles (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) python(abi) python3.12dist(anyio) rtld(GNU_HASH) python-watchfiles-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-watchfiles: python-watchfiles python3-watchfiles python3-watchfiles(aarch-64) python3.12-watchfiles python3.12dist(watchfiles) python3dist(watchfiles) python-watchfiles-debugsource: python-watchfiles-debugsource python-watchfiles-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2240154 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, Python Disabled plugins: Ocaml, C/C++, PHP, Perl, Haskell, SugarActivity, Java, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) CC0 is only allowed for content: https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Maybe check if upstream for rust library can also use Public Domain Dedication or offer some other approved license? b) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106527960
> a) CC0 is only allowed for content: > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ > Maybe check if upstream for rust library can also use Public Domain Dedication or offer some other approved license? This package doesn't have CC0 code. It buildrequires the existing rust-notify package, which is CC0. rust-notify was added to Fedora in 2019 [0], predating the policy change to disallow CC0 for code [1]. The only reason it is mentioned in this spec file is that the package guidelines require indicating the licenses of any statically linked code, which is how rust works [2]. This should not be a blocker for this package review. [0] https://src.fedoraproject.org/rpms/rust-notify/c/95da26115b23c11cdd03d038994939083aae3b57?branch=rawhide [1] https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/RRYM3CLYJYW64VSQIXY6IF3TCDZGS6LM/ [2] https://docs.fedoraproject.org/en-US/legal/license-field/#_rust_packages
For context: I'm the maintainer of the notify / notify-debouncer-mini crates in Fedora. I've asked Fedora Legal for help with these two, and the conclusion was that they fall under the documented "grandparenting" exception, i.e. existing packages in Fedora that use CC0-1.0 license for code are OK. This is also documented in the license data maintained by Fedora Legal: https://gitlab.com/fedora/legal/fedora-license-data/-/blob/main/data/CC0-1.0.toml#L11-L14 I have also asked upstream about possibly relicensing the code in the future, so the "CC0-1.0" license might even to away in the future.
Thanks. Approved. Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2239129 https://bugzilla.redhat.com/show_bug.cgi?id=2218338 https://bugzilla.redhat.com/show_bug.cgi?id=2237325 Would be appreciated if time and interest allow.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-watchfiles
FEDORA-2023-e91d05da9d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e91d05da9d
FEDORA-2023-e91d05da9d has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-a0eb52b8c0 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a0eb52b8c0
FEDORA-2023-a0eb52b8c0 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a0eb52b8c0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a0eb52b8c0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-a0eb52b8c0 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.