Spec URL: https://music.fedorapeople.org/python-pycatch22.spec SRPM URL: https://music.fedorapeople.org/python-pycatch22-0.4.3-1.fc38.src.rpm Description: catch22 is a collection of 22 time-series features coded in C that can be run from Python, R, Matlab, and Julia. This package provides a Python implementation as the module pycatch22. Fedora Account System Username: music Koji scratch builds: F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=107016727 (Needs https://src.fedoraproject.org/rpms/catch22/pull-request/3 backported in order to build for older releases. The plan is to do this after import, in side tags with the initial builds of this package.) If reviewed before the next successful Rawhide compose, fedora-review may need --mock-options=--enablerepo=local. This replaces the obsolete bindings packaged (prior to F40) as the python3-catch22 subpackage of the catch22 package. It will be a neuro-sig package.
Reviewing this now. :)
LGTM XX APPROVED XX Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [-]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3". 13 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2241911-python- pycatch22/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3560 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pycatch22 [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pycatch22-0.4.3-1.fc40.x86_64.rpm python-pycatch22-debugsource-0.4.3-1.fc40.x86_64.rpm python-pycatch22-0.4.3-1.fc40.src.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpi9wycoby')] checks: 31, packages: 3 python-pycatch22.spec: W: patch-not-applied Patch0: 0001-Downstream-only-use-unbundled-catch22-library.patch ^ False positive ============================================ 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s =========================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Unversioned so-files -------------------- python3-pycatch22: /usr/lib64/python3.12/site-packages/catch22_C.cpython-312-x86_64-linux-gnu.so ^ This is fine Source checksums ---------------- https://github.com/DynamicsAndNeuralSystems/pycatch22/archive/v0.4.3/pycatch22-0.4.3.tar.gz : CHECKSUM(SHA256) this package : d2509db935c2a22ad81f0872a8b1c9a4bd09859fb62bd34131739aacfeae8a3c CHECKSUM(SHA256) upstream package : d2509db935c2a22ad81f0872a8b1c9a4bd09859fb62bd34131739aacfeae8a3c Requires -------- python3-pycatch22 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcatch22.so.0.1()(64bit) python(abi) rtld(GNU_HASH) python-pycatch22-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-pycatch22: python-pycatch22 python3-pycatch22 python3-pycatch22(x86-64) python3.12-pycatch22 python3.12dist(pycatch22) python3dist(pycatch22) python-pycatch22-debugsource: python-pycatch22-debugsource python-pycatch22-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2241911 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic, Python Disabled plugins: fonts, PHP, Perl, Haskell, SugarActivity, Ocaml, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review!
Added to release monitoring: https://release-monitoring.org/project/264843/
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pycatch22
FEDORA-2023-60b2173cc8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-60b2173cc8
FEDORA-2023-60b2173cc8 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-d628a8636c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d628a8636c
FEDORA-2023-7b254b17d9 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b254b17d9
FEDORA-2023-97060f3872 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-97060f3872
FEDORA-2023-97060f3872 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-97060f3872 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-97060f3872 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-d628a8636c has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d628a8636c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d628a8636c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-7b254b17d9 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7b254b17d9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b254b17d9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-97060f3872 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-7b254b17d9 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-d628a8636c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.