Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kxmlgui/kf6-kxmlgui.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kxmlgui/kf6-kxmlgui-5.240.0^20231010.021754.3365b4a-1.fc39.src.rpm Description: KDE Frameworks 6 Tier 3 solution for user-configurable main windows. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/6513869 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243059-kf6-kxmlgui/fedora-rawhide-x86_64/06513869-kf6-kxmlgui/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
BuildRequires: cmake(KF6Attica) BuildRequires: cmake(KF6WindowSystem) should be unused. BuildRequires: cmake(KF6TextWidgets) is only used for building tests %{_kf6_qtplugindir}/designer/*6widgets.so should probably go to -devel
Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kxmlgui/kf6-kxmlgui.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kxmlgui/kf6-kxmlgui-5.240.0^20231010.021754.3365b4a-1.fc39.src.rpm Removed unneeded build requires and moved a library over to the devel subpkg
Created attachment 1993260 [details] The .spec file difference from Copr build 6513869 to 6513958
Copr build: https://copr.fedorainfracloud.org/coprs/build/6513958 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243059-kf6-kxmlgui/fedora-rawhide-x86_64/06513958-kf6-kxmlgui/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6513966 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243059-kf6-kxmlgui/fedora-rawhide-x86_64/06513966-kf6-kxmlgui/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/56940
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kxmlgui