Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kbookmarks/kf6-kbookmarks.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kbookmarks/kf6-kbookmarks-5.240.0^20231009.021624.89d7de2-1.fc39.src.rpm Description: KBookmarks lets you access and manipulate bookmarks stored using the XBEL format. Fedora Account System Username: farchord
Copr build: https://copr.fedorainfracloud.org/coprs/build/6514497 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243108-kf6-kbookmarks/fedora-rawhide-x86_64/06514497-kf6-kbookmarks/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6514624 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243108-kf6-kbookmarks/fedora-rawhide-x86_64/06514624-kf6-kbookmarks/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Meh, did it locally... Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
BuildRequires: cmake(KF6XmlGui) is unused %{_kf6_libdir}/libKF6BookmarksWidgets.so.5* %{_kf6_libdir}/libKF6BookmarksWidgets.so.6* looks weird, for libKF6Bookmarks there's only one glob
Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/56958
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kbookmarks