Bug 2244400 - Please build python-lark for F38
Summary: Please build python-lark for F38
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: python-lark
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tomáš Hrnčiar
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2244406
TreeView+ depends on / blocked
 
Reported: 2023-10-16 11:21 UTC by Sandro
Modified: 2023-10-18 23:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-18 23:01:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Sandro 2023-10-16 11:21:18 UTC
I will be putting a package up for review shortly that I intent to release for all current branches (F38+) and it requires `lark`.

Building from rawhide in Copr for F38 shows the package builds fine without any modifications:

https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-38-x86_64/06529618-python-lark/

Reproducible: Always

Comment 1 Miro Hrončok 2023-10-18 12:39:36 UTC
python3-lark obsoletes python3-lark-parser which is in Fedora 38. Adding it to Fedora 38 would probably go against the spirit of https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/


If you want, you can:


 - patch/sed the requirement from lark to lark-parser on Fedora < 39 only
 - patch/sed the requirement from lark to lark-parser on all Fedoras (python3-lark has a backward compatibility shim for the metadata)
 - propose a similar forward compatibility shim for the metadata in the python3-lark-parser package

Comment 2 Sandro 2023-10-18 13:09:16 UTC
(In reply to Miro Hrončok from comment #1)
> python3-lark obsoletes python3-lark-parser which is in Fedora 38. Adding it
> to Fedora 38 would probably go against the spirit of
> https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/

Aren't these the same packages? This also came up in the package review (bug 2227008 comment 8). If so, this would be a simple renaming of the package.

https://pypi.org/project/lark-parser/ and https://pypi.org/project/lark/ both point at the same home page: https://github.com/lark-parser/lark

Comment 3 Miro Hrončok 2023-10-18 13:33:12 UTC
> Aren't these the same packages?

Pretty much, but they are called differently :/

Comment 4 Sandro 2023-10-18 14:04:45 UTC
(In reply to Miro Hrončok from comment #3)
> > Aren't these the same packages?
> 
> Pretty much, but they are called differently :/

Hence renaming python-lark-parser to python-lark and updating is the correct way forward. Or is it difficult / impossible because python3-lark-parser provides `python3dist(lark-parser)` instead of `python3dist(lark)`? If so, I can live with not introducing my package in F38.

Comment 5 Miro Hrončok 2023-10-18 21:51:06 UTC
`python3dist(lark-parser)` vs `python3dist(lark)` is what makes it difficult, yes.

I'd rather not do this in Fedora 38. I guess you can package RTFDE like this:

  # Loosen upper bound on lark, allow lark-parser (Fedora 38)
  sed -i -e 's/lark==1.1.5/lark-parser>=0.9/' setup.py

Does that work?

Comment 6 Sandro 2023-10-18 22:54:17 UTC
It seems the older version is not compatible as is:

E   ImportError: cannot import name 'logger' from 'lark' (/usr/lib/python3.11/site-packages/lark/__init__.py)

I'll take a closer look when I can find the time. If all else fails, I will simply not introduce python-RTFDE to F38 as I stated before.

But this bug can be closed. Not worth the headaches nor the time, I think. Thanks for your help!


Note You need to log in before you can comment on or make changes to this bug.